Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ParseSSE function causing Leo to get cut off #21018

Merged
merged 1 commit into from
Nov 17, 2023
Merged

Fix ParseSSE function causing Leo to get cut off #21018

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/api_request_helper/api_request_helper.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -453,7 +453,7 @@ void APIRequestHelper::URLLoaderHandler::ParseSSE(
};

DVLOG(2) << "Going to call ParseJson";
GetDataDecoder()->ParseJson(std::move(json.data()),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm curious how this behaved/s before and after.

std::move(json.data()) is unusual, doesn't make sense and behaved sporadically odd.

for a moment, let's examine this: json.data() returns a const char*, the consumer of this pointer reads char up to the null terminator string.

how did this end up with sentence cut-offs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://bravesoftware.slack.com/archives/C05NDQP03AQ/p1700249757581809?thread_ts=1699393531.992589&cid=C05NDQP03AQ

GetDataDecoder()->ParseJson(std::move(std::string(json)),
base::BindOnce(std::move(on_json_parsed),
weak_ptr_factory_.GetWeakPtr()));
}
Expand Down