[iOS] Enable History datatype for Sync #20642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3e3ccb2 to
be7214a
Compare
kylehickinson
approved these changes
Oct 24, 2023
|
@soner-yuksel If you ping me when this is merged, I can cherry-pick it into the cr119 uplift for you. Just let me know. |
@emerick sounds excellent that will save me from making uplifts 😄 |
c4ca039 to
5bd0aac
Compare
25 tasks
emerick
pushed a commit
that referenced
this pull request
Oct 25, 2023
kjozwiak
pushed a commit
that referenced
this pull request
Oct 26, 2023
* Enable History datatype for Sync (#20329) * Reverted PR#16705 (Sync all history) * Reverted PR#16478 (Display history sync diagnostic info) * Reverted PR#20071 (Disable history sync datatype to fallback to typed urls datatype) * Added overrides for HistoryModelTypeController and HistoryDeleteDirectivesModelTypeController to work when encrypt everything option is on * Add patch to sync history delete directives and history entities together * Added unit test for LowPriorityUserTypes * Enable encryption of history sync entities * Added test for precondition state of history datatype controllers * Modified: clean out HistoryDeleteDirectiveSpecifics::UrlDirective::url field, as it is unencrypted * Added test to ensure we don't send url at HistoryDeleteDirectiveSpecifics::UrlDirective * Modified ModelTypeTest.EncryptableUserTypes test to check History type * Removed 'path_excludes' for the files removed in the current PR --------- Co-authored-by: Darnell Andries <dandries@brave.com> * Fix #33746: Cleanup Brave-Core iOS chromium_src overrides & initialization code (#20598) - Cleanup Brave-Core IOS Chromium_SRC overrides. - Add new cleaner Chromium_SRC overrides and simplify app launch logic. * Don't redefine static_assert (#20440) (Instead, we make sure the static_assert passes here by locally restoring kCoarseResolutionMicroseconds back to its original Chromium value.) * Use `PrefService` with `MigrateObsoleteProfilePrefs` (#20396) Upstream is changing `MigrateObsoleteProfilePrefs` to take a `PrefService` pointer, rather than `Profile`, as this is more expressive of the data actually being accessed. This change aligns all places where we have procedures similar to `MigrateObsoleteProfilePrefs`, to receive a `PrefService*` instance as well. Chromium change: https://chromium.googlesource.com/chromium/src/+/d848587fe1f19123940de4e4c0cec328bc23001f commit d848587fe1f19123940de4e4c0cec328bc23001f Author: Mikel Astiz <mastiz@chromium.org> Date: Mon Oct 2 09:28:03 2023 +0000 [sync] Remove legacy SyncRequested pref It has been practically unused for some time, and most of it is dead code ever since the feature toggle was cleaned up in https://crrev.com/c/4886256. On Ash, it needs to be migrated to a newly-introduced preference tailored to the actual underlying need, which is being able to remember that the server returned DISABLE_SYNC_ON_CLIENT (i.e. the user reset sync via dashboard). Change-Id: I0239447173b32d7d007ebf733dde23a5de1859e1 Bug: 1443446, 1219990 * Ignore formatting for crates under `third_party` (#20390) This changes adds a patch to add brave's own third party crates path to the list of rust paths to be ignored during formatting. * Merge pull request #20642 from brave/ios/bugfix/sync_all_history * Merge pull request #20664 from brave/cr119-followup-disable-power-bookmarks Disable kPowerBookmarksSidePanel feature flag * [Android] Fix for private tab badge padding Chromium change: https://source.chromium.org/chromium/chromium/src/+/37d04b2089c15cb152a8a559887a7d10c66572be [APS] Update tooltip visibility and remove hover highlight for StatusView - Remove tooltip when StatusIconView is not visible. - remove hover highlight when StatusIconView is not visible(e.g. default engine is not Google). - remove hover highlight when VerboseStatusText is visible(e.g. offline). demo(default engine not Google): https://drive.google.com/file/d/1DPIhHtWN4RnjPvkysyCSfV_gd73ZMjPb/view?usp=sharing demo(offline) https://drive.google.com/file/d/1-1Y_t59i8AcxFv6sLpBE-kG2tsSGoi4s/view?usp=sharing TODO: relocate the logic in StatusView to StatusViewBinder or StatusProperties. Bug: 1476816, 1476802 * Merge pull request #20314 from brave/cr119 Upgrade from Chromium 118 to Chromium 119 --------- Co-authored-by: AlexeyBarabash <AlexeyBarabash@users.noreply.github.com> Co-authored-by: Darnell Andries <dandries@brave.com> Co-authored-by: Brandon-T <bthomas@brave.com> Co-authored-by: Arthur Edelstein <aedelstein@brave.com> Co-authored-by: cdesouza-chromium <cdesouza@brave.com> Co-authored-by: Soner YUKSEL <grkmyksl@gmail.com> Co-authored-by: Artem Samoilenko <artem@brave.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the changes for iOS History API after history datatype enabled inside Brave. iOs refecltion of this particular PR #20329
Resolves brave/brave-browser#33839
iOS Ticket - PR to allow All History Items Sync:
brave/brave-ios#8305
brave/brave-ios#8306
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on