Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SocialBlockingBrowserProxyImpl class name #1987

Merged
merged 1 commit into from
Mar 18, 2019

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Mar 18, 2019

Fix brave/brave-browser#3760

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Verified that all lint errors/warnings are resolved (npm run lint)
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bbondy bbondy added this to the 0.64.x - Nightly milestone Mar 18, 2019
@bbondy bbondy self-assigned this Mar 18, 2019
@bbondy bbondy requested a review from pilgrim-brave March 18, 2019 12:52
@bbondy bbondy merged commit 19b0c9f into master Mar 18, 2019
bbondy added a commit that referenced this pull request Mar 18, 2019
Fix SocialBlockingBrowserProxyImpl class name
bbondy added a commit that referenced this pull request Mar 18, 2019
Fix SocialBlockingBrowserProxyImpl class name
@mihaiplesa mihaiplesa deleted the social-blocking-proxy-fix branch May 13, 2019 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use correct social blocking proxy impl class name
2 participants