-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Wallet) Enable Filecoin support flag #18881
Conversation
77e1ac2
to
1f52bab
Compare
0c73a7d
to
6f6cd36
Compare
Calculates gas fee for Filecoins and adjust amount.
dca6dfc
to
c9adf52
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File coin test net send has issue with network, asset, and balance. Desktop has no asset for filecoin test net send, the filecoin test case works?
file-coin-testnet.webm
android/java/org/chromium/chrome/browser/crypto_wallet/util/ParsedTransactionFees.java
Outdated
Show resolved
Hide resolved
Thanks, on it! |
} else { | ||
String result; | ||
try { | ||
BigInteger minued = new BigInteger(maxFeePerGasDecimal); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minuend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed, thanks!
@Pavneet-Sing, the issue was related to the logic used to distinguish between network types. Improved the check to distinguish between mainnet and testnet for Filecoins in the commit Re-requesting a review, thanks! |
@@ -287,29 +287,10 @@ private void addAccountInternal(@CoinType.EnumType int coinType, | |||
result -> { handleAddAccountResult(result, callback); }); | |||
} | |||
|
|||
private static @KeyringId.EnumType int getTargetKeyringId( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method removed as duplicate of AssetUtils.getKeyring
.
Resolves brave/brave-browser#30342
Resolves brave/brave-browser#30402
Security review issue https://github.com/brave/security/issues/1321
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: