Use EvalJS without EXECUTE_SCRIPT_USE_MANUAL_REPLY
#18754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the use of EvalJs in a similar fashion done upstream, removing on the uses of `content::EXECUTE_SCRIPT_USE_MANUAL_REPLY`, and modifying the scripts used in tests to return values directly, rather than relying on `domAutomationController` to transmit back results, which can be finicky. With the new approach, values are returned through promises, or directly as a return value.
186d3b1 to
bf2db3b
Compare
25 tasks
emerick
pushed a commit
that referenced
this pull request
Jun 20, 2023
This PR changes the use of EvalJs in a similar fashion done upstream, removing on the uses of `content::EXECUTE_SCRIPT_USE_MANUAL_REPLY`, and modifying the scripts used in tests to return values directly, rather than relying on `domAutomationController` to transmit back results, which can be finicky. With the new approach, values are returned through promises, or directly as a return value.
emerick
pushed a commit
that referenced
this pull request
Jun 20, 2023
This PR changes the use of EvalJs in a similar fashion done upstream, removing on the uses of `content::EXECUTE_SCRIPT_USE_MANUAL_REPLY`, and modifying the scripts used in tests to return values directly, rather than relying on `domAutomationController` to transmit back results, which can be finicky. With the new approach, values are returned through promises, or directly as a return value.
kjozwiak
pushed a commit
that referenced
this pull request
Jun 23, 2023
* Merge pull request #18388 from brave/cr115 Upgrade from Chromium 114 to Chromium 115 * [CodeHealth] Removing `base::Value` `Find*Path` uses This PR removes the use of deprecated base::Value functions that are set to be deleted upstream, namely FindPath, and its companions. Chromium change: https://chromium.googlesource.com/chromium/src/+/99a884ced145f4086403439df9dc4bb21a406077 commit 99a884ced145f4086403439df9dc4bb21a406077 Author: Andrew Rayskiy <greengrape@google.com> Date: Tue May 16 08:50:44 2023 +0000 [CodeHealth] Remove FindPath() from base/values.{h,cc} R=dcheng@chromium.org Bug: 1439196 * base::Value::FindBoolKey removed upstream Chromium change: https://chromium.googlesource.com/chromium/src/+/0fc824ae4dfcc4ab4f60cf4be99a50fe5fb4b984 commit 0fc824ae4dfcc4ab4f60cf4be99a50fe5fb4b984 Author: Matthew Riley <mattdr@google.com> Date: Tue May 9 23:37:26 2023 +0000 Remove FindBoolKey All uses have been removed Bug: 1187001 * Use EvalJS without `EXECUTE_SCRIPT_USE_MANUAL_REPLY` (#18754) This PR changes the use of EvalJs in a similar fashion done upstream, removing on the uses of `content::EXECUTE_SCRIPT_USE_MANUAL_REPLY`, and modifying the scripts used in tests to return values directly, rather than relying on `domAutomationController` to transmit back results, which can be finicky. With the new approach, values are returned through promises, or directly as a return value. * Merge pull request #18970 from brave/cr115-followup-create-new-profile-button-colors Import polymer_overriding.js to get cr-button branding overrides --------- Co-authored-by: Claudio DeSouza <cdesouza@igalia.com> Co-authored-by: cdesouza-chromium <cdesouza@brave.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the use of EvalJs in a similar fashion done upstream, removing on the uses of
content::EXECUTE_SCRIPT_USE_MANUAL_REPLY, and modifying the scripts used in tests to return values directly, rather than relying ondomAutomationControllerto transmit back results, which can be finicky.With the new approach, values are returned through promises, or directly as a return value.
Resolves
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_testswikinpm run lint,npm run presubmitwiki,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: