-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hide third-party cookies toggle from Cookies and Site Data popup #18550
Hide third-party cookies toggle from Cookies and Site Data popup #18550
Conversation
8d0e9d4
to
86f1a08
Compare
86f1a08
to
d085c76
Compare
NOTREACHED_NORETURN(); | ||
} | ||
|
||
+ BRAVE_HIDE_COOKIES_BLOCK_CONTROL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't we just disable kPageInfoCookiesSubpage
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to disable kPageInfoCookiesSubpage
.
9088267
to
2b87a43
Compare
Now that the PageSpecificSiteDataDialog is enabled by default, we want to use it but we need to remove the "Block third-party cookies" toggle. Chromium change: https://source.chromium.org/chromium/chromium/src/+/261c8555a61041682df175ac5914588ec39e765a commit 261c8555a61041682df175ac5914588ec39e765a Author: Olesia Marukhno <olesiamarukhno@google.com> Date: Wed Apr 5 12:06:09 2023 +0000 [site data] Enable PageSpecificSiteDataDialog by default Bug: 1344787
2b87a43
to
bec4baa
Compare
…ggle-from-site-data-popup Hide third-party cookies toggle from Cookies and Site Data popup
…ggle-from-site-data-popup Hide third-party cookies toggle from Cookies and Site Data popup
Verification PASSED on
Using the STR/Cases outlined via brave/brave-browser#30396 (comment), ensured that the Clean Install
Upgraded Profile
|
Now that the PageSpecificSiteDataDialog is enabled by default, we want to use it but we need to remove the "Block third-party cookies" toggle.
Resolves brave/brave-browser#30396
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run lint
,npm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: