Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjusted vpn sell panel's text alignment #17378

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 27, 2023

fix brave/brave-browser#28755

image

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

@simonhong simonhong self-assigned this Feb 27, 2023
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Feb 27, 2023
@simonhong simonhong requested a review from nullhook February 27, 2023 03:15
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@simonhong simonhong merged commit bb2909e into master Feb 27, 2023
@simonhong simonhong deleted the polish_vpn_sell_panel branch February 27, 2023 10:36
@github-actions github-actions bot added this to the 1.50.x - Nightly milestone Feb 27, 2023
brave-builds added a commit that referenced this pull request Feb 27, 2023
@stephendonner
Copy link
Contributor

Verified PASSED using

Brave 1.50.71 Chromium: 111.0.5563.33 (Official Build) nightly (x86_64)
Revision 19bd6d0186b7912604e18191826dab9d1df00e2e-refs/branch-heads/5563@{#557}
OS macOS Version 11.7.4 (Build 20G1120)

Confirmed the Protects you from unwanted network connections text is now properly wrapped

Screen Shot 2023-02-28 at 11 50 21 AM

kjozwiak pushed a commit that referenced this pull request Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align text on Brave VPN promotion screen
4 participants