Added 'Manifest V2 extensions' section in settings. #16983

boocmp · 2023-02-02T12:06:14Z

Resolves brave/brave-browser#28367

extensions_v2.mp4

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Launch Brave with ExtensionsManifestV2 feature enabled:

brave-browser --enable-features=ExtensionsManifestV2

Go to brave://settings/extensions
Click to Manifest V2 Extensions section
You should see 4 extensions
Enable/Disable toggles will install/uninstall corresponding extensions

brave-builds · 2023-02-03T02:36:38Z

A Storybook has been deployed to preview UI for the latest push

iefremov · 2023-02-07T15:06:49Z

pls file a ticket with a link to the spec

brave-builds · 2023-02-14T13:31:54Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-15T02:45:55Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-02-15T15:33:47Z

A Storybook has been deployed to preview UI for the latest push

antonok-edm

We probably want another review for the strings, but I added my own suggestions.

antonok-edm · 2023-02-17T19:56:41Z

app/brave_settings_strings.grdp

+    Manifest V2 extensions
+  </message>
+  <message name="IDS_SETTINGS_MANAGE_EXTENSIONS_V2_SUBLABEL" desc="The sub label of manage v2 extensions link in settings">
+    The following Manifest V2 extensions are no longer available in the Chrome Web Store, but still supported in Brave. Click to download and install.


They are technically still available in the Chrome Web Store and should be for much longer, but will be increasingly difficult to find there over time. I suggest rewording to something like:

The following Manifest V2 extensions will be removed from the Chrome Web Store, but are still supported in Brave. Click to download and install.

antonok-edm · 2023-02-17T20:04:32Z

app/brave_settings_strings.grdp

+    Close
+  </message>
+  <message name="IDS_SETTINGS_MANAGE_EXTENSIONS_V2_NO_SCRIPT_NAME" desc="Manifest V2 extension toggle's label">
+    Enable NoScript&#x2122;


I'm not an expert on this kind of thing, just raising a potential concern:

Is it appropriate to be using ™ for all of these? AdGuard maybe (although they use © on their website), but the others are released under GPLv3 and don't appear to have any registered trademark.

@rebron asked me to add trademarks. Rafael what do you think?

Yes, confirmed with @bradleyrichter.

antonok-edm · 2023-02-17T20:43:33Z

app/brave_settings_strings.grdp

+    Enable uBlock Origin&#x2122;
+  </message>
+  <message name="IDS_SETTINGS_MANAGE_EXTENSIONS_V2_UBLOCK_ORIGIN_DESC" desc="Manifest V2 extension toggle's sub label">
+    uBlock Origin is a Manifest V2 extension that provides ad blocking features and controls specific to uBlock.


uBlock Origin is a Manifest V2 extension that provides powerful content blocking tools with lots of options for advanced users.

antonok-edm · 2023-02-17T20:44:06Z

app/brave_settings_strings.grdp

+    Enable uMatrix&#x2122;
+  </message>
+  <message name="IDS_SETTINGS_MANAGE_EXTENSIONS_V2_UMATRIX_DESC" desc="Manifest V2 extension toggle's sub label">
+    uMatrix is a Manifest V2 extension that provides point-and-click matrix-based firewall, with many privacy-enhancing tools.


uMatrix is a Manifest V2 extension that provides point-and-click matrix-based firewall, with many privacy-enhancing tools.

antonok-edm · 2023-02-17T20:44:14Z

app/brave_settings_strings.grdp

+    uMatrix is a Manifest V2 extension that provides point-and-click matrix-based firewall, with many privacy-enhancing tools.
+  </message>
+  <message name="IDS_SETTINGS_MANAGE_EXTENSIONS_V2_ADGUARD_NAME" desc="Manifest V2 extension toggle's label">
+    Enable AdBlock&#x2122;


antonok-edm · 2023-02-17T21:30:11Z

app/brave_settings_strings.grdp

+    Enable AdBlock&#x2122;
+  </message>
+  <message name="IDS_SETTINGS_MANAGE_EXTENSIONS_V2_ADGUARD_DESC" desc="Manifest V2 extension toggle's sub label">
+    AdGuard is a Manifest V2 extension that effectively blocks all types of ads on all web pages, even on Facebook, YouTube and others.


AdGuard is a Manifest V2 extension that provides ad blocking, parental control options, and integration with other AdGuard service offerings.

TM is useful to identify these extension names as "not Brave's thing" and TM has loose rules for usage. Any company can claim a TM but it carries little value without official registration which then earns you an ®.

iefremov · 2023-03-07T14:45:05Z

browser/ui/webui/settings/brave_extensions_manifest_v2_handler.cc

+      browser_context != web_ui()->GetWebContents()->GetBrowserContext()) {
+    return;
+  }
+  auto fnd = std::find_if(extensions_.begin(), extensions_.end(),


base::ranges::find

iefremov

patches/* and the C++ part lgtm

brave-builds · 2023-03-07T16:53:32Z

A Storybook has been deployed to preview UI for the latest push

petemill

The WebUI Polymer code looks good!

petemill · 2023-03-07T17:47:23Z

app/brave_settings_strings.grdp

+    Manifest V2 extensions
+  </message>
+  <message name="IDS_SETTINGS_MANAGE_EXTENSIONS_V2_SUBLABEL" desc="The sub label of manage v2 extensions link in settings">
+    The following Manifest V2 extensions will be removed from the Chrome Web Store, but are still supported in Brave. Click to download and install.


Should this be "toggle to download and install, or to uninstall" (not focusing on the word "click" and also conveying that it will be uninstalled when untoggled)?

cc: @rmcfadden3 Any suggestions on the text. Also, @boocmp We can finalize text with a follow-up. I wouldn't consider this blocking.

Per Slack convo with @rebron , let's go with this:

The following Manifest V2 extensions will be removed from the Chrome Web Store, but still be supported in Brave. Toggle on an individual extension to download / install it, or toggle off to uninstall / remove.

petemill · 2023-03-07T17:50:42Z

...r/resources/settings/brave_default_extensions_page/brave_extensions_manifest_v2_subpage.html

@@ -0,0 +1,56 @@
+<style include="cr-shared-style">
+  #errorMessage {
+    align-items: center;


nit: align-items should be colocated with display: flex, flex-direction, and gap (or anything which affects children's layout

petemill · 2023-03-07T17:51:44Z

...r/resources/settings/brave_default_extensions_page/brave_extensions_manifest_v2_subpage.html

+    display: flex;
+    flex-direction: row;
+    gap: 16px;
+    left: 50%;


nit: left should be colocated with the other position items

brave-builds · 2023-03-08T04:25:55Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-03-09T16:53:58Z

A Storybook has been deployed to preview UI for the latest push

brave-builds · 2023-03-10T02:35:11Z

A Storybook has been deployed to preview UI for the latest push

boocmp requested a review from iefremov February 2, 2023 12:06

boocmp requested a review from a team as a code owner February 2, 2023 12:06

github-actions bot assigned boocmp Feb 2, 2023

github-actions bot added CI/storybook-url Deploy storybook and provide a unique URL for each build potential-layer-violation-fixes This PR touches a BUILD.gn file with check_includes=false labels Feb 2, 2023

boocmp force-pushed the ext_manifest_v2 branch from 3b79ae5 to 44b9c35 Compare February 3, 2023 01:41

antonok-edm self-requested a review February 10, 2023 18:33

boocmp requested a review from petemill February 12, 2023 07:16

boocmp force-pushed the ext_manifest_v2 branch from 44b9c35 to 3dae27c Compare February 14, 2023 12:17

boocmp force-pushed the ext_manifest_v2 branch from 3dae27c to 491d9fe Compare February 15, 2023 02:05

boocmp force-pushed the ext_manifest_v2 branch from 491d9fe to 62e0cc7 Compare February 15, 2023 14:13

antonok-edm reviewed Feb 17, 2023

View reviewed changes

boocmp force-pushed the ext_manifest_v2 branch from 62e0cc7 to 86e42c3 Compare February 27, 2023 10:57

boocmp force-pushed the ext_manifest_v2 branch from 86e42c3 to 7ecf2a4 Compare March 7, 2023 14:13

iefremov reviewed Mar 7, 2023

View reviewed changes

iefremov approved these changes Mar 7, 2023

View reviewed changes

petemill approved these changes Mar 7, 2023

View reviewed changes

boocmp force-pushed the ext_manifest_v2 branch from 4aeb113 to f9f0078 Compare March 8, 2023 03:30

boocmp enabled auto-merge (squash) March 8, 2023 10:45

boocmp force-pushed the ext_manifest_v2 branch from f9f0078 to 9714201 Compare March 9, 2023 16:00

boocmp added 2 commits March 10, 2023 09:05

Added 'Manifest V2 extensions' section in settings.

5f4308d

Added browser tests.

3fa7d32

boocmp added 4 commits March 10, 2023 09:05

Added 'ExtensionsManifestV2' feature.

5390049

Added Trademarks & new error message dialog.

b539b36

Updated strings.

5bcaabd

Rebased & review issues are addressed.

0203107

boocmp force-pushed the ext_manifest_v2 branch from 9714201 to 0203107 Compare March 10, 2023 02:05

boocmp merged commit db91beb into master Mar 10, 2023

boocmp deleted the ext_manifest_v2 branch March 10, 2023 04:17

github-actions bot added this to the 1.51.x - Nightly milestone Mar 10, 2023

bsclifton mentioned this pull request Mar 5, 2024

Brave Extension Store brave/brave-browser#15187

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added 'Manifest V2 extensions' section in settings. #16983

Added 'Manifest V2 extensions' section in settings. #16983

boocmp commented Feb 2, 2023 •

edited by fmarier

Loading

brave-builds commented Feb 3, 2023

iefremov commented Feb 7, 2023

brave-builds commented Feb 14, 2023

brave-builds commented Feb 15, 2023

brave-builds commented Feb 15, 2023

antonok-edm left a comment

antonok-edm Feb 17, 2023

antonok-edm Feb 17, 2023

boocmp Feb 18, 2023

rebron Feb 21, 2023

antonok-edm Feb 17, 2023

antonok-edm Feb 17, 2023

antonok-edm Feb 17, 2023

antonok-edm Feb 17, 2023

bradleyrichter Feb 21, 2023

iefremov Mar 7, 2023

iefremov left a comment

brave-builds commented Mar 7, 2023

petemill left a comment

petemill Mar 7, 2023 •

edited

Loading

rebron Mar 8, 2023

rmcfadden3 Mar 9, 2023

petemill Mar 7, 2023

petemill Mar 7, 2023

brave-builds commented Mar 8, 2023

brave-builds commented Mar 9, 2023

brave-builds commented Mar 10, 2023

Added 'Manifest V2 extensions' section in settings. #16983

Added 'Manifest V2 extensions' section in settings. #16983

Conversation

boocmp commented Feb 2, 2023 • edited by fmarier Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

brave-builds commented Feb 3, 2023

iefremov commented Feb 7, 2023

brave-builds commented Feb 14, 2023

brave-builds commented Feb 15, 2023

brave-builds commented Feb 15, 2023

antonok-edm left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

iefremov left a comment

Choose a reason for hiding this comment

brave-builds commented Mar 7, 2023

petemill left a comment

Choose a reason for hiding this comment

petemill Mar 7, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

brave-builds commented Mar 8, 2023

brave-builds commented Mar 9, 2023

brave-builds commented Mar 10, 2023

boocmp commented Feb 2, 2023 •

edited by fmarier

Loading

petemill Mar 7, 2023 •

edited

Loading