Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the feature conditions for notification permission #16807

Merged
merged 1 commit into from
Jan 23, 2023

Conversation

deeppandya
Copy link
Contributor

@deeppandya deeppandya commented Jan 23, 2023

Checking for a feature before the permission check

Resolves brave/brave-browser#27982

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Checking for feature t=before the permission
@deeppandya deeppandya added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Jan 23, 2023
@deeppandya deeppandya added this to the 1.49.x - Nightly milestone Jan 23, 2023
@deeppandya deeppandya self-assigned this Jan 23, 2023
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@deeppandya deeppandya merged commit e49f398 into master Jan 23, 2023
@deeppandya deeppandya deleted the dp_resolve_permission_check branch January 23, 2023 20:15
@kjozwiak
Copy link
Member

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.49.55 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 12; Build/SP1A.210812.016
  • once installed on a fresh/new profile, restarted Brave ~5-6 times and ensured it didn't crash
  • quickly spot checked the notification warning modals and ensured they're working/appearing as expected
Example Example Example Example
Screenshot_20230123-224329_Brave - Nightly Screenshot_20230123-224347_Brave - Nightly Screenshot_20230123-224458_Brave - Nightly Screenshot_20230123-224515_Brave - Nightly

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.49.55 Chromium: 109.0.5414.87 (Official Build) canary (32-bit)
--- | ---
Revision | 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS | Android 13; Build/TQ1A.230105.002
  • once installed on a fresh/new profile, restarted Brave ~5-6 times and ensured it didn't crash
  • quickly spot checked the notification warning modals and ensured they're working/appearing as expected
Example Example Example
Screenshot_20230123-225212 Screenshot_20230123-225518 Screenshot_20230123-225532

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash on startup due to notifications check
3 participants