Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .style.yapf. #16424

Merged
merged 2 commits into from
Dec 20, 2022
Merged

Add .style.yapf. #16424

merged 2 commits into from
Dec 20, 2022

Conversation

goodov
Copy link
Member

@goodov goodov commented Dec 20, 2022

We have a PR in review which revealed a yapf dict formatting bug. I don't want to merge that PR with such weird formatting (it's enforced via format checks). Instead we can introduce a correct style which won't trigger this issue.

This PR adds style config with Chromium defaults and a workaround for dict formatting.
PEP-8 style has INDENT_WIDTH=4 by default, most of our files are formatted with indent=4, that's why I didn't add it explicitly to the config.

Resolves brave/brave-browser#27467

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov enabled auto-merge (squash) December 20, 2022 11:39
@goodov goodov disabled auto-merge December 20, 2022 13:27
@goodov goodov merged commit 3618262 into master Dec 20, 2022
@goodov goodov deleted the yapf-style branch December 20, 2022 14:02
@github-actions github-actions bot added this to the 1.48.x - Nightly milestone Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default yapf style format dicts incorrectly
2 participants