Update webpack, webpack-cli and associated plugins and loaders to latest webpack-v4-supporting versions #16317

petemill · 2022-12-09T20:33:11Z

Had to change a couple of ways that webpack config was built.

First step in to journey for updating to webpack v5 brave/brave-browser#22351

Resolves brave/brave-browser#27282

Submitter Checklist:

I confirm that no security/privacy review is needed, or that I have requested one
There is a ticket for my issue
Used Github auto-closing keywords in the PR description above
Wrote a good PR/commit description
Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
Checked the PR locally:
- npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
- npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
Ran git rebase master (if needed)

Reviewer Checklist:

A security review is not needed, or a link to one is included in the PR description
New files have MPL-2.0 license header
Adequate test coverage exists to prevent regressions
Major classes, functions and non-trivial code blocks are well-commented
Changes in component dependencies are properly reflected in gn
Code follows the style guide
Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

diracdeltas

yay for less deps! g2g from me assuming audit-deps passes

github-actions · 2022-12-09T20:34:19Z

⚠️ PR head is an unsigned commit
commit: d739b49ea4f0b02d4f97f00342aca29f6f917d52
reason: unsigned
Please follow the handbook to configure commit signing
cc: @petemill

evenstensberg

Let me know if I can be of any help :)

fallaciousreasoning

LGTM! Thanks for doing this @petemill (looks like audit-deps is failing though)

petemill · 2022-12-12T19:02:22Z

Yep I've got audit-deps in a position where only 1 dep is causing it to fail failing due to the following chain

├─┬ typescript-plugin-css-modules@4.1.1
│ └─┬ postcss-icss-selectors@2.0.3
│   └─┬ generic-names@1.0.3
│     └── loader-utils@0.2.17

I'm struggling with an override that works on first install and then reverts to a bad version 🤷

  "overrides": {
    "typescript-plugin-css-modules": {
      "loader-utils": "1.4.1"
    },

petemill · 2022-12-13T01:28:20Z

Removed the typescript-plugin-css-modules plugin for now since it doesn't affect the build. It was only used as an editor nicety and isn't used very much

mihaiplesa · 2023-10-04T21:37:06Z

Related #20369

…est webpack-v4-supporting versions

evenstensberg

would it be useful to upgrade to webpack 5 instead of v4?

fallaciousreasoning · 2023-11-15T21:12:35Z

Yup, I'm having a play around with Webpack5 at the moment, but there's a bunch of funky stuff going on (brave-ui isn't playing nice). The changes here are a prerequisite for it anyway and @petemill has already done the work

github-actions · 2023-11-15T21:13:49Z

package-lock.json

      "dev": true
    },
+    "node_modules/trim-newlines": {
+      "version": "1.0.0",


_{reported by reviewdog 🐶}
[npm-audit] Uncontrolled Resource Consumption in trim-newlines

See GHSA-7p7h-4mm5-852v
Cc @fmarier @thypon

socket-security · 2023-11-15T21:29:08Z

New, updated, and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Packages	Version	New capabilities	Transitives	Size	Publisher
css-loader	5.2.7	None	`+5`	245 kB	evilebottnawi
@storybook/addons	6.4.13...6.5.14	None	`+16/-24`	2.69 MB	shilman
webpack-cli	3.3.12...4.10.0	None	`+13/-20`	692 kB	evilebottnawi
@storybook/react	6.4.13...6.5.14	filesystem	`+274/-251`	41.1 MB	shilman
@storybook/addon-essentials	6.4.13...6.5.14	None	`+165/-265`	29.6 MB	shilman
sass-loader	10.2.1...10.4.1	None	`+1/-1`	131 kB	evilebottnawi
style-loader	0.23.1...2.0.0	None	`+1/-0`	143 kB	evilebottnawi
babel-loader	8.2.3...8.3.0	None	`+10/-10`	2.67 MB	nicolo-ribaudo

🚮 Removed packages: file-loader@1.1.11, url-loader@1.0.0

…-css-modules to fix audit

fallaciousreasoning · 2023-11-16T00:11:43Z

Bump to Webpack5: #21003

petemill requested a review from fallaciousreasoning December 9, 2022 20:33

petemill requested a review from a team as a code owner December 9, 2022 20:33

petemill self-assigned this Dec 9, 2022

github-actions bot added the CI/run-audit-deps Check for known npm/cargo vulnerabilities (audit_deps) label Dec 9, 2022

diracdeltas approved these changes Dec 9, 2022

View reviewed changes

evenstensberg reviewed Dec 11, 2022

View reviewed changes

fallaciousreasoning approved these changes Dec 11, 2022

View reviewed changes

petemill force-pushed the webpack-4-latest branch 2 times, most recently from 5fa07ad to b8374de Compare December 13, 2022 01:27

mihaiplesa mentioned this pull request Oct 4, 2023

Bump postcss, @storybook/addon-essentials, @storybook/react, css-loader and typescript-plugin-css-modules #20369

Closed

Update webpack, webpack-cli and associated plugins and loaders to lat…

57e7ab7

…est webpack-v4-supporting versions

fallaciousreasoning force-pushed the webpack-4-latest branch from b8374de to 342ed6c Compare November 15, 2023 21:08

evenstensberg reviewed Nov 15, 2023

View reviewed changes

github-actions bot reviewed Nov 15, 2023

View reviewed changes

github-actions bot added the needs-security-review label Nov 15, 2023

github-actions bot assigned fmarier and thypon Nov 15, 2023

Update storybook to 6.5.14 from 6.4.13, also remove typescript-plugin…

ba5c10c

…-css-modules to fix audit

fallaciousreasoning force-pushed the webpack-4-latest branch from 342ed6c to ba5c10c Compare November 15, 2023 21:56

fallaciousreasoning mentioned this pull request Nov 27, 2023

[Dependencies]: Upgrade to Webpack 5 #21003

Merged

25 tasks

fallaciousreasoning closed this in #21003 Dec 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update webpack, webpack-cli and associated plugins and loaders to latest webpack-v4-supporting versions #16317

Update webpack, webpack-cli and associated plugins and loaders to latest webpack-v4-supporting versions #16317

petemill commented Dec 9, 2022 •

edited

Loading

diracdeltas left a comment

github-actions bot commented Dec 9, 2022

evenstensberg left a comment

fallaciousreasoning left a comment •

edited

Loading

petemill commented Dec 12, 2022

petemill commented Dec 13, 2022

mihaiplesa commented Oct 4, 2023

evenstensberg left a comment

fallaciousreasoning commented Nov 15, 2023

github-actions bot Nov 15, 2023

socket-security bot commented Nov 15, 2023

fallaciousreasoning commented Nov 16, 2023

Update webpack, webpack-cli and associated plugins and loaders to latest webpack-v4-supporting versions #16317

Update webpack, webpack-cli and associated plugins and loaders to latest webpack-v4-supporting versions #16317

Conversation

petemill commented Dec 9, 2022 • edited Loading

Submitter Checklist:

Reviewer Checklist:

After-merge Checklist:

Test Plan:

diracdeltas left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2022

evenstensberg left a comment

Choose a reason for hiding this comment

fallaciousreasoning left a comment • edited Loading

Choose a reason for hiding this comment

petemill commented Dec 12, 2022

petemill commented Dec 13, 2022

mihaiplesa commented Oct 4, 2023

evenstensberg left a comment

Choose a reason for hiding this comment

fallaciousreasoning commented Nov 15, 2023

github-actions bot Nov 15, 2023

Choose a reason for hiding this comment

socket-security bot commented Nov 15, 2023

fallaciousreasoning commented Nov 16, 2023

petemill commented Dec 9, 2022 •

edited

Loading

fallaciousreasoning left a comment •

edited

Loading