Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the size of Windows Group Policy templates #15845

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

mherrmann
Copy link
Collaborator

brave_policy_templates.zip is now 4 MiB instead of 40.

Resolves brave/brave-browser#26611

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

As in #15440, while making sure that policy_templates.zip is < 5 MiB in size.

brave_policy_templates.zip is now 4 MiB instead of 40.
@mherrmann mherrmann requested a review from goodov November 8, 2022 09:56
@mherrmann mherrmann self-assigned this Nov 8, 2022
@mherrmann mherrmann enabled auto-merge (squash) November 8, 2022 11:03
@mherrmann mherrmann merged commit d907660 into master Nov 8, 2022
@mherrmann mherrmann deleted the reduce-win-group-policy-template-size branch November 8, 2022 12:07
@github-actions github-actions bot added this to the 1.47.x - Nightly milestone Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows Group Policy Template zip is too large
2 participants