Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zero address handling for EnsGetEthAddr #15169

Merged
merged 1 commit into from
Sep 22, 2022
Merged

Conversation

supermassive
Copy link
Collaborator

@supermassive supermassive commented Sep 22, 2022

Resolves brave/brave-browser#25308

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

'Send to' wallet panel should respond with no address for haimoura.eth instead of 0x000....00000 address

@supermassive supermassive requested a review from a team as a code owner September 22, 2022 03:26
@supermassive supermassive merged commit 330f5f7 into master Sep 22, 2022
@supermassive supermassive deleted the fix_ens_zero_address branch September 22, 2022 05:38
@github-actions github-actions bot added this to the 1.46.x - Nightly milestone Sep 22, 2022
supermassive added a commit that referenced this pull request Sep 22, 2022
@yrliou yrliou restored the fix_ens_zero_address branch September 22, 2022 18:59
@supermassive supermassive deleted the fix_ens_zero_address branch September 23, 2022 01:59
@srirambv
Copy link
Contributor

Verification passed on

Brave 1.46.4 Chromium: 106.0.5249.55 (Official Build) nightly (64-bit)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS Linux
  • Verified entering haimoura.eth in Send to on wallet panel shows Domain haimoura.eth is not registered message instead of zero address
  • Verified on both Panel and widget
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect address for ENS domains without eth address record.
3 participants