Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design bugs in Tor Bridges Settings. #14996

Merged
merged 5 commits into from
Sep 15, 2022
Merged

Design bugs in Tor Bridges Settings. #14996

merged 5 commits into from
Sep 15, 2022

Conversation

boocmp
Copy link
Contributor

@boocmp boocmp commented Sep 6, 2022

Resolves brave/brave-browser#25183
Resolves brave/brave-browser#25155
Resolves brave/brave-browser#25268
Resolves brave/brave-browser#25294

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

Video
https://user-images.githubusercontent.com/73575789/189667785-588500a5-76d2-4283-9fb3-317ed3ed1141.mp4

@boocmp boocmp requested a review from petemill September 6, 2022 06:24
@boocmp boocmp self-assigned this Sep 6, 2022
@boocmp boocmp requested a review from iefremov September 6, 2022 06:26
@boocmp boocmp changed the title Issues/25183 Design bugs in Tor Bridges Settings. Sep 8, 2022
@fmarier
Copy link
Member

fmarier commented Sep 8, 2022

Might be worth fixing the typo in https://github.com/brave/brave-core/pull/14914/files#r966283015 as well.

@boocmp
Copy link
Contributor Author

boocmp commented Sep 12, 2022

Might be worth fixing the typo in https://github.com/brave/brave-core/pull/14914/files#r966283015 as well.

Yep, done

@boocmp boocmp merged commit 5b39cbc into master Sep 15, 2022
@boocmp boocmp deleted the issues/25183 branch September 15, 2022 12:43
@github-actions github-actions bot added this to the 1.45.x - Nightly milestone Sep 15, 2022
@stephendonner
Copy link
Contributor

stephendonner commented Sep 16, 2022

Verification PASSED using

Brave 1.45.53 Chromium: 105.0.5195.136 (Official Build) nightly (x86_64)
Revision 872774b783d0e674186a3adcd2f92e7aa22a219c-refs/branch-heads/5195_124@{#4}
OS macOS Version 13.0 (Build 22A5342f)

Issue 25183:

Confirmed jank is gone when toggling Use Bridges to Enabled and Disabled

bridge-collapse

Issue 25155:

Confirmed it now reads the plural, places

Screenshot 2022-09-15 at 9 41 48 PM

Issue 25268:

Confirmed Cancel and Submit are in the correct (for macOS) order, and with the appropriate spacing between them

Screenshot 2022-09-15 at 9 53 04 PM

Issue 25294:

Confirmed it now reads Snowflake

Screenshot 2022-09-15 at 9 37 49 PM

Unfiled; reported via Slack:

Confirmed we now match the Tor Browser's list in order and capitalization

Screenshot 2022-09-15 at 9 50 44 PM

Confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants