Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only hide sidebar when tab-initiated fullscreen mode (uplift to 1.44.x) #14840

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Only hide sidebar when tab-initiated fullscreen mode (uplift to 1.44.x) #14840

merged 1 commit into from
Aug 29, 2022

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Aug 26, 2022 •
edited by kjozwiak
Loading

Uplift of #14790
fix brave/brave-browser#16160

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner August 26, 2022 00:48
@brave-builds brave-builds self-assigned this Aug 26, 2022
@brave-builds brave-builds added this to the 1.44.x - Beta milestone Aug 26, 2022
@simonhong simonhong self-assigned this Aug 26, 2022
kjozwiak
kjozwiak approved these changes Aug 29, 2022
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.44.x approved 👍 QA has verified the PR on Nightly as per #14790 (comment).

@kjozwiak kjozwiak merged commit fdc6899 into 1.44.x Aug 29, 2022
@kjozwiak kjozwiak deleted the pr14790_tab_fullscreen_sidebar_1.44.x branch August 29, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@simonhong simonhong

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.44.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@brave-builds @kjozwiak @simonhong @brave-browser-releases