Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cr105 follow up] Fixes favicon in Shields Panel. #14816

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#24954

The chrome://favicon2 syntax has changed to camelCase.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/78e45e119c9aca1eabf7e0b23764d1923f25a720

commit 78e45e119c9aca1eabf7e0b23764d1923f25a720
Author: Solomon Kinard solomonkinard@chromium.org
Date: Mon Jun 13 23:45:53 2022 +0000

Favicon: Use camelCase params instead of snake_case in JS context

Doc:
https://docs.google.com/document/d/1ksvSq1zF-9jYSfGOvNluyoTV0Ud9xl6r9HiAKONqmz8

Context: crrev.com/c/3673461

Bug: 104102

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Aug 24, 2022
Copy link
Contributor

@nullhook nullhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Fixes brave/brave-browser#24954

The chrome://favicon2 syntax has changed to camelCase.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/78e45e119c9aca1eabf7e0b23764d1923f25a720

commit 78e45e119c9aca1eabf7e0b23764d1923f25a720
Author: Solomon Kinard <solomonkinard@chromium.org>
Date:   Mon Jun 13 23:45:53 2022 +0000

    Favicon: Use camelCase params instead of snake_case in JS context

    Doc:
    https://docs.google.com/document/d/1ksvSq1zF-9jYSfGOvNluyoTV0Ud9xl6r9HiAKONqmz8

    Context: crrev.com/c/3673461

    Bug: 104102
@mkarolin mkarolin force-pushed the maxk-fix-shields-favicon branch from 3d52c06 to 15ec8a1 Compare August 25, 2022 02:53
@mkarolin mkarolin merged commit 9afd6a5 into master Aug 25, 2022
@mkarolin mkarolin deleted the maxk-fix-shields-favicon branch August 25, 2022 13:33
@mkarolin mkarolin added this to the 1.45.x - Nightly milestone Aug 25, 2022
mkarolin added a commit that referenced this pull request Aug 25, 2022
[cr105 follow up] Fixes favicon in Shields Panel.
brave-builds pushed a commit that referenced this pull request Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Correct site favicons are not displayed in the Shields panel
2 participants