Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed don't ask check of private window's closing confirm dialog doesn't work #14734

Merged
merged 1 commit into from
Aug 23, 2022

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Aug 22, 2022

fix brave/brave-browser#24829

Setting prefs to private profile is not persisted.
Always set it to orignal profile.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

See the linked issue

…n't work

fix brave/brave-browser#24829

Setting prefs to private profile is not persisted.
Always set it to orignal profile.
@simonhong simonhong requested a review from sangwoo108 August 22, 2022 10:36
@simonhong simonhong self-assigned this Aug 22, 2022
@simonhong simonhong marked this pull request as ready for review August 22, 2022 10:36
Copy link
Contributor

@sangwoo108 sangwoo108 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@simonhong simonhong merged commit 86b1feb into master Aug 23, 2022
@simonhong simonhong deleted the closing_confirm_dialog_private_window branch August 23, 2022 00:40
@simonhong simonhong added this to the 1.44.x - Nightly milestone Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Don't ask me again" setting in "Close all tabs?" prompt has no effect from private window
2 participants