Upgrade from Chromium 104 to Chromium 105. #13946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonhong
reviewed
Jun 27, 2022
browser/ui/views/infobars/brave_wayback_machine_infobar_contents_view.cc
Show resolved
Hide resolved
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
simonhong
reviewed
Jun 28, 2022
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
|
A Storybook has been deployed to preview UI for the latest push |
The implementation has been rolled into base/check.cc Chromium change: https://source.chromium.org/chromium/chromium/src/+/ae771d5e5f53750982036a5aee7088e4d2e6017d commit ae771d5e5f53750982036a5aee7088e4d2e6017d Author: Peter Boström <pbos@chromium.org> Date: Fri Jul 15 18:48:05 2022 +0000 Reland "Reland "Update NOTREACHED() macro to dump once on ash"" This reverts commit 78a16418ffb133b4dda77bb78bcbadc4ffa56e57. Reason for revert: Third time's the charm? Original change's description: > Revert "Reland "Update NOTREACHED() macro to dump once on ash"" > > This reverts commit a49185f54a399e0942ed93e2a57119d99aef71a0. > > Reason for revert: Still failing on linux-chromeos-rel > Example: > https://ci.chromium.org/ui/p/chromium/builders/ci/linux-chromeos-rel/57998/test-results > > Original change's description: > > Reland "Update NOTREACHED() macro to dump once on ash" > > > > This reverts commit 0936342e1f6be815cc2476e67a6b76baf6f21eaa. > > > > Reason for revert: Relanding with updated test expectations. > > > > Original change's description: > > > Revert "Update NOTREACHED() macro to dump once on ash" > > > > > > This reverts commit 0877630af0544722fad407c4966a64af8c7fa2c3. > > > > > > Reason for revert: CheckTest.NotReached test consistently failing. > > > > > > First failure: > > > https://ci.chromium.org/ui/p/chromium/builders/ci/chromeos-amd64-generic-rel/65871/overview > > > > > > Original change's description: > > > > Update NOTREACHED() macro to dump once on ash > > > > > > > > It's not immediately obvious that ash will get DCHECK_IS_CONFIGURABLE > > > > builds, so this provides some extra NOTREACHED() information for > > > > non-DCHECK builds where NOTREACHED()s are not optimized out but are > > > > logged anyways. > > > > > > > > This adds DCheckDumpOnceWithoutCrashing support to NOTREACHED() under > > > > the gn arg `enable_log_error_not_reached`. > > > > > > > > For other release builds (including official non-DCHECK builds) this is > > > > optimized away through EAT_CHECK_STREAM_PARAMS(). > > > > > > > > notreached.cc is removed in favor of using CheckError and friends. > > > > NOTREACHED() as a macro should probably move into perhaps check.h. > > > > > > > > Bug: 596231
../../brave/vendor/bat-native-ads/src/bat/ads/internal/account/utility/redeem_unblinded_token/create_confirmation_util.cc(52,36): error: call to deleted constructor of 'base::Value::Dict'
confirmation_request_dto.Merge(std::move(user_data->GetDict()));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../..\base/values.h(377,5): note: 'Dict' has been explicitly marked deleted here
Dict(const Dict&) = delete;
^
../..\base/values.h(444,21): note: passing argument to parameter 'dict' here
void Merge(Dict dict);
^
1 error generated.
These tests pass locally, but crash on x86 CI.
We change colors so this is not expected to work.
Applied upstream changes https://source.chromium.org/chromium/chromium/src/+/405506fdd359e49f8c741f4483164f1d62bb447f to fix build warning: ../../chrome/android/java/src/org/chromium/chrome/browser/share/ShareDelegateImpl.java:265: Warning: This method should only be accessed from tests or within private scope [VisibleForTests] if (profile == null || !profile.isNativeInitialized()) { ~~~~~~~~~~~~~~~~~~~ 0 errors, 1 warnings (613 errors, 237 warnings filtered by baseline lint-baseline.xml) Chromium change: chromium/chromium@4ec45d2 [SharingHub] Add Profile fallback and null-check back. Sometimes Profile.ProfileSupplier is unexpectedly returning null, so add the null-check back so it doesn't cause crashes. (cherry picked from commit 5ad5f44) Bug: 1346710
Replaces commenting out with line by line patching.
|
A Storybook has been deployed to preview UI for the latest push |
Just added the necessary code to compile. No implementation fo the feature for Brave side panel. Chromium change: https://source.chromium.org/chromium/chromium/src/+/1183a7f341a2c95040f3677ed052ab1609ca22d3 commit 1183a7f341a2c95040f3677ed052ab1609ca22d3 Author: dljames <dljames@google.com> Date: Tue Jul 19 19:09:18 2022 +0000 [Side Panel] Side switch feature implementation. Implementation of the side switch feature for side panel. This implementation works with the recently added side panel prefs. Also supports RTL side switching. Change-Id: I59e260aaabd38cb324fc956ba398e100dd00022a Bug: 1318892
|
A Storybook has been deployed to preview UI for the latest push |
mkarolin
added a commit
that referenced
this pull request
Aug 24, 2022
Upgrade from Chromium 104 to Chromium 105.
25 tasks
mkarolin
added a commit
that referenced
this pull request
Aug 25, 2022
Upgrade from Chromium 104 to Chromium 105.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#23800
Submitter Checklist:
QA/YesorQA/No;release-notes/includeorrelease-notes/exclude;OS/...) to the associated issuenpm run test -- brave_browser_tests,npm run test -- brave_unit_tests,npm run lint,npm run gn_check,npm run tslintgit rebase master(if needed)Reviewer Checklist:
gnAfter-merge Checklist:
changes has landed on
Test Plan: