Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix multiple sync issues #1221

Merged
merged 1 commit into from
Jan 7, 2019
Merged

fix multiple sync issues #1221

merged 1 commit into from
Jan 7, 2019

Conversation

cezaraugusto
Copy link
Contributor

fix multiple sync issues

related to #1193
sibling PR in brave-ui brave/brave-ui#337

@cezaraugusto cezaraugusto self-assigned this Jan 4, 2019
@cezaraugusto cezaraugusto changed the title Merge pull request #1193 from brave/ca-sync fix multiple sync issues Jan 4, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2019 •
edited
Loading

Uplifts for dev don't require an approval from one of the approvals mentioned under https://github.com/brave/brave-browser/wiki/Triage-Guidelines#uplift-approvers. You'll still need an approval, but you're not required to get one from the following folks:

Current approvers are @rebron @kjozwiak @Sri @bbondy @clifton (Slack usernames).

beta and release uplifts requires an approval from one of the above folks.

@cezaraugusto cezaraugusto mentioned this pull request Jan 7, 2019
Merged
@cezaraugusto
Merge pull request #1193 from brave/ca-sync
3dbb4e8 
fix multiple sync issues
bsclifton
bsclifton approved these changes Jan 7, 2019
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 3a40def into 0.60.x Jan 7, 2019
@cezaraugusto cezaraugusto deleted the ca-sync-60 branch January 7, 2019 16:35
@bbondy bbondy added this to the 0.60.x - Dev milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@rebron rebron Awaiting requested review from rebron

@kjozwiak kjozwiak Awaiting requested review from kjozwiak

@srirambv srirambv Awaiting requested review from srirambv

@bbondy bbondy Awaiting requested review from bbondy

Assignees

@cezaraugusto cezaraugusto

Labels
feature/sync
Projects
None yet
Milestone
0.60.x - Release
Development

Successfully merging this pull request may close these issues.
4 participants
@cezaraugusto @kjozwiak @bsclifton @bbondy