Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

call Initialize at the time that brave ads is disabled, not on shut… #1149

Merged
merged 1 commit into from
Dec 19, 2018
Merged

call Initialize at the time that brave ads is disabled, not on shut… #1149

merged 1 commit into from
Dec 19, 2018

Conversation

bridiver
Copy link
Collaborator

@bridiver bridiver commented Dec 19, 2018 •
edited
Loading

…down

fix brave/brave-browser#2639

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@bridiver bridiver self-assigned this Dec 19, 2018
@bridiver bridiver requested a review from tmancey December 19, 2018 20:37
@bridiver bridiver merged commit eff91d5 into master Dec 19, 2018
@bridiver bridiver deleted the issues/2639 branch December 19, 2018 20:43
bridiver added a commit that referenced this pull request Dec 20, 2018
@bridiver
Merge pull request #1149 from /issues/2639
ec81afb 
call `Initialize` at the time that brave ads is disabled, not on shut…
@bridiver
Copy link
Collaborator Author

0.60.x ec81afb

@rebron
Copy link
Collaborator

rebron commented Dec 20, 2018

Approving uplift-request for 0.59.x-beta. cc: @kjozwiak cc: @srirambv

tmancey pushed a commit that referenced this pull request Dec 20, 2018
@bridiver @tmancey
Merge pull request #1149 from /issues/2639
f6fadaa 
call `Initialize` at the time that brave ads is disabled, not on shut…
@bbondy bbondy added this to the 0.59.x - Beta milestone Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmancey tmancey tmancey approved these changes

Assignees

@bridiver bridiver

Labels
feature/ads
Projects
None yet
Milestone
0.59.x - Release
Development

Successfully merging this pull request may close these issues.

Brave Ads is disabled on browser exit potentially resetting Ads state
4 participants
@bridiver @rebron @tmancey @bbondy