Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchEngineTracker: Re-enable DefaultSearchEngineP3A test. #10328

Merged
merged 3 commits into from
Oct 2, 2021

Conversation

rillian
Copy link
Contributor

@rillian rillian commented Sep 30, 2021

This was disabled in 27bf9e3 for intermittent failures.
Add a call to wait for TemplateURLServiceFactory to finish
loading, and re-enable to see if that stabilizes the browser
test.

See brave/brave-browser#13057 for tracking.

This duplicates VerifyTemplateURLServiceLoad() from the
search_engine_provider browser test, but it's a small piece
of code and having two file-local implementations is simple
enough.

Resolves

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@rillian rillian self-assigned this Sep 30, 2021
@rillian rillian requested a review from iefremov September 30, 2021 18:51
@rillian rillian mentioned this pull request Sep 30, 2021
24 tasks
@rillian rillian requested a review from bsclifton September 30, 2021 19:07
Copy link
Contributor

@iefremov iefremov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once we just use verbatim search_test_utils::WaitForTemplateURLServiceToLoad(service);

This was disabled in 27bf9e3 for intermittent failures.
Add a call to wait for TemplateURLServiceFactory to finish
loading, and re-enable to see if that stabilizes the browser
test.

See brave/brave-browser#13057 for tracking.

This duplicates VerifyTemplateURLServiceLoad() from the
search_engine_provider browser test, but it's a small piece
of code and having two file-local implementations is simple
enough.
WaitForTemplateURLServiceLoad() already checks service->loaded()
and asserts if the notification callback completes without changing
the state, so the wrapper is redundant except for the better test
failure message.

Addresses a review comment from Ivan Efremov.
@rillian
Copy link
Contributor Author

rillian commented Oct 2, 2021

As far as I can tell, the intermittent macOS ci failures aren't related.

@rillian rillian merged commit 5a6b4dc into master Oct 2, 2021
@rillian rillian deleted the p3a-search-test branch October 2, 2021 00:31
@bsclifton
Copy link
Member

Nice work 😄 Thanks for getting these back in @rillian!

@bsclifton bsclifton added this to the 1.32.x - Nightly milestone Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants