Skip to content

Commit

Permalink
Add guards against displaying the translation overlay when other popu…
Browse files Browse the repository at this point in the history
…ps are displayed.
  • Loading branch information
Brandon-T committed Feb 25, 2025
1 parent 0176850 commit ec9e508
Showing 1 changed file with 6 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ extension BrowserViewController: BraveTranslateScriptHandlerDelegate {
}

return Preferences.Translate.translateEnabled.value == nil
&& !topToolbar.inOverlayMode
&& topToolbar.secureContentState == .secure
&& Preferences.Translate.translateURLBarOnboardingCount.value < 2
&& shouldShowTranslationOnboardingThisSession && presentedViewController == nil
Expand Down Expand Up @@ -100,6 +101,11 @@ extension BrowserViewController: BraveTranslateScriptHandlerDelegate {
}

func presentToast(tab: Tab?, languageInfo: BraveTranslateLanguageInfo) {
if presentedViewController != nil || topToolbar.inOverlayMode || tab !== tabManager.selectedTab
{
return
}

let popover = PopoverController(
content: TranslateToast(languageInfo: languageInfo) { [weak tab] _ in
tab?.translateHelper?.startTranslation(canShowToast: false)
Expand Down

0 comments on commit ec9e508

Please sign in to comment.