Skip to content

Commit

Permalink
[cr93 followup] Disables kReadLater feature.
Browse files Browse the repository at this point in the history
  • Loading branch information
mkarolin committed Aug 20, 2021
1 parent 057901f commit 84def00
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions app/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ include_rules = [
"+components/offline_pages/core/offline_page_feature.h",
"+components/omnibox/common",
"+components/password_manager/core/common",
"+components/reading_list/features/reading_list_switches.h",
"+components/safe_browsing/core/common/features.h",
"+components/security_state/core/features.h",
"+components/signin/public/base",
Expand Down
2 changes: 2 additions & 0 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
#include "components/offline_pages/core/offline_page_feature.h"
#include "components/omnibox/common/omnibox_features.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/reading_list/features/reading_list_switches.h"
#include "components/security_state/core/features.h"
#include "components/sync/base/sync_base_switches.h"
#include "components/translate/core/browser/translate_prefs.h"
Expand Down Expand Up @@ -227,6 +228,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
network::features::kTrustTokens.name,
network_time::kNetworkTimeServiceQuerying.name,
password_manager::features::kEnablePasswordsAccountStorage.name,
reading_list::switches::kReadLater.name,
#if defined(OS_ANDROID)
features::kWebNfc.name,
feed::kInterestFeedContentSuggestions.name,
Expand Down
2 changes: 2 additions & 0 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
#include "components/network_time/network_time_tracker.h"
#include "components/omnibox/common/omnibox_features.h"
#include "components/password_manager/core/common/password_manager_features.h"
#include "components/reading_list/features/reading_list_switches.h"
#include "components/security_state/core/features.h"
#include "content/public/browser/render_view_host.h"
#include "content/public/common/content_features.h"
Expand Down Expand Up @@ -93,6 +94,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&network::features::kTrustTokens,
&network_time::kNetworkTimeServiceQuerying,
&password_manager::features::kEnablePasswordsAccountStorage,
&reading_list::switches::kReadLater,
};

for (const auto* feature : disabled_features)
Expand Down
2 changes: 2 additions & 0 deletions test/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -705,6 +705,7 @@ if (!is_android) {
"//brave/vendor/bat-native-ads",
"//brave/vendor/bat-native-ledger",
"//brave/vendor/bat-native-ledger:publishers_proto",
"//components/reading_list/features:flags",
"//components/security_interstitials/content:security_interstitial_page",
"//components/user_prefs",
"//media:test_support",
Expand Down Expand Up @@ -967,6 +968,7 @@ if (!is_android) {
"//components/federated_learning",
"//components/language/core/common",
"//components/network_time",
"//components/reading_list/features:flags",
"//components/spellcheck/browser",
"//services/device/public/cpp:device_features",

Expand Down

0 comments on commit 84def00

Please sign in to comment.