Hide skip buttons by default, fix retained legacy p3a callout

brave · Feb 25, 2025 · 8121f63 · 8121f63
1 parent 54a0f1e
commit 8121f63
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Callout.swift b/ios/brave-ios/Sources/Brave/Frontend/Browser/BrowserViewController/BVC+Callout.swift
@@ -73,7 +73,7 @@ extension BrowserViewController {
           toggleAction: { [weak self] isOn in
             self?.braveCore.p3aUtils.isP3AEnabled = isOn
           },
-          linkAction: { url in
+          linkAction: { [unowned onboardingP3ACalloutController] url in
             let p3aLearnMoreController = SFSafariViewController(
               url: .brave.p3aHelpArticle,
               configuration: .init()

diff --git a/ios/brave-ios/Sources/Onboarding/WelcomeFocus/OnboardingView.swift b/ios/brave-ios/Sources/Onboarding/WelcomeFocus/OnboardingView.swift
@@ -46,7 +46,7 @@ public class OnboardingController: UIHostingController<OnboardingRootView> {
     environment: OnboardingEnvironment,
     steps: [any OnboardingStep] = .allSteps,
     showSplashScreen: Bool = true,
-    showDismissButton: Bool = true,
+    showDismissButton: Bool = false,
     onCompletion: @escaping () -> Void = {}
   ) {
     super.init(