Skip to content

Commit

Permalink
Disables Live Caption feature.
Browse files Browse the repository at this point in the history
We need to follow up on this to proxy component download and also fiture
out API keys maybe as it currently doesn't work.

Chromium change:

https://source.chromium.org/chromium/chromium/src/+/9b46507cf5a5ee1460dc9c20307206d7cb004a2f

commit 9b46507cf5a5ee1460dc9c20307206d7cb004a2f
Author: evliu <evliu@google.com>
Date:   Fri Mar 5 00:49:23 2021 +0000

    Enable the Live Caption feature by default

    This CL enables the LiveCaption, UseSodaForLiveCaption, and IPH_LiveCaption features by default.

    Bug: 1182008
  • Loading branch information
mkarolin committed May 18, 2021
1 parent 5acfba9 commit 58b5841
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 1 deletion.
1 change: 1 addition & 0 deletions app/DEPS
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ include_rules = [
"+components/dom_distiller/core/dom_distiller_switches.h",
"+google_apis/gaia",
"+gpu/config",
"+media/base/media_switches.h",
"+services/device",
"+services/network",
"-third_party/blink",
Expand Down
2 changes: 2 additions & 0 deletions app/brave_main_delegate.cc
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@
#include "content/public/common/content_features.h"
#include "content/public/common/content_switches.h"
#include "google_apis/gaia/gaia_switches.h"
#include "media/base/media_switches.h"
#include "net/base/features.h"
#include "services/device/public/cpp/device_features.h"
#include "services/network/public/cpp/features.h"
Expand Down Expand Up @@ -226,6 +227,7 @@ bool BraveMainDelegate::BasicStartupComplete(int* exit_code) {
features::kWebOTP.name,
federated_learning::kFederatedLearningOfCohorts.name,
federated_learning::kFlocIdComputedEventLogging.name,
media::kLiveCaption.name,
net::features::kFirstPartySets.name,
network::features::kTrustTokens.name,
network_time::kNetworkTimeServiceQuerying.name,
Expand Down
2 changes: 2 additions & 0 deletions app/brave_main_delegate_browsertest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#include "content/public/common/content_features.h"
#include "content/public/test/browser_test.h"
#include "gpu/config/gpu_finch_features.h"
#include "media/base/media_switches.h"
#include "net/base/features.h"
#include "services/device/public/cpp/device_features.h"
#include "services/network/public/cpp/features.h"
Expand Down Expand Up @@ -84,6 +85,7 @@ IN_PROC_BROWSER_TEST_F(BraveMainDelegateBrowserTest, DisabledFeatures) {
&federated_learning::kFederatedLearningOfCohorts,
&federated_learning::kFlocIdComputedEventLogging,
&kEnableProfilePickerOnStartupFeature,
&media::kLiveCaption,
&net::features::kFirstPartySets,
&network::features::kTrustTokens,
&network_time::kNetworkTimeServiceQuerying,
Expand Down
3 changes: 2 additions & 1 deletion chromium_src/chrome/app/BUILD.gn
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

group("app") {
deps = [
"//google_apis"
"//google_apis",
"//media",
]
}

0 comments on commit 58b5841

Please sign in to comment.