Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate NTP Super Referrer(SR) component #97

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Generate NTP Super Referrer(SR) component #97

merged 1 commit into from
Mar 23, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Mar 10, 2020 •
edited
Loading

@simonhong simonhong self-assigned this Mar 10, 2020
@simonhong simonhong force-pushed the super-referrer-package branch 2 times, most recently from ddbf29e to 7031ab4 Compare March 10, 2020 23:08
@simonhong simonhong requested a review from petemill March 10, 2020 23:24
@anthonypkeane anthonypkeane mentioned this pull request Mar 10, 2020
Closed
6 tasks
@simonhong
Copy link
Member Author

This PR works well with https://ci.brave.com/view/all-extensions/job/brave-core-ext-ntp-super-referrer-component-dev/

@simonhong simonhong requested a review from bsclifton March 13, 2020 02:16
@simonhong simonhong force-pushed the super-referrer-package branch from 7031ab4 to 7b21dea Compare March 16, 2020 02:08
@simonhong simonhong force-pushed the super-referrer-package branch from 7b21dea to c097f65 Compare March 16, 2020 02:22
@simonhong simonhong changed the title Generate NTP Super Referreer(SR) component Generate NTP Super Referrer(SR) component Mar 16, 2020
bsclifton
bsclifton reviewed Mar 17, 2020
View reviewed changes
scripts/generateNTPSuperReferrer.js
console.log(`Downloading for ${referrerName}...`)
const targetResourceDir = path.join(rootResourceDir, referrerName)
mkdirp.sync(targetResourceDir)
const jsonFileUrl = `${dataUrl}superreferrer/${referrerName}/${jsonFileName}`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful- so this just uses the iOS URL to get the resources? 😎👍

Copy link
Member Author

@simonhong simonhong Mar 18, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Jenkins job, our s3 bucket full url is passed. but not sure iOS dev will use same url or alias url.

bsclifton
bsclifton approved these changes Mar 23, 2020
View reviewed changes
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bsclifton bsclifton merged commit d18b9fe into brave:master Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsclifton bsclifton bsclifton approved these changes

@petemill petemill Awaiting requested review from petemill

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @bsclifton