Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uplift request group policy for tor to 0.73.x (#6475) #6830

Closed
wants to merge 1 commit into from
Closed

Uplift request group policy for tor to 0.73.x (#6475) #6830

wants to merge 1 commit into from

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Nov 7, 2019 •
edited
Loading

Uplift of #6475

Issue: #454
Issue: #6044

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@simonhong simonhong added this to the 0.73.x - Dev milestone Nov 7, 2019
@simonhong simonhong self-assigned this Nov 7, 2019
@simonhong simonhong changed the title Merge pull request #6475 from brave/group_policy_for_tor Uplift request group policy for tor to 0.73.x (#6475) Nov 7, 2019
@simonhong simonhong mentioned this pull request Nov 11, 2019
Closed
4 tasks
@simonhong @brave-browser-releases
Merge pull request #6475 from brave/group_policy_for_tor
149e80b 
Replace chrome branding strings in management_strings.grdp
@brave-builds brave-builds force-pushed the uplift_group_policy_tor_0_73 branch from de2872f to 149e80b Compare November 11, 2019 04:21
kjozwiak
kjozwiak reviewed Nov 11, 2019
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 0.73.x denied after deliberating with @brave/uplift-approvers and several other folks. Because this feature wasn't set to land in any particular release, we're going to let it ride the trains rather than uplifting into both 0.73.x and 0.72.x. Uplifting this right into 0.72.x will cause some risk as the feature won't really have much time to bake on the other channels.

@kjozwiak kjozwiak closed this Nov 11, 2019
@kjozwiak kjozwiak removed this from the 0.73.x - Dev milestone Nov 11, 2019
@kjozwiak kjozwiak deleted the uplift_group_policy_tor_0_73 branch November 11, 2019 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak left review comments

@bbondy bbondy Awaiting requested review from bbondy

@bsclifton bsclifton Awaiting requested review from bsclifton

@rebron rebron Awaiting requested review from rebron

Assignees

@simonhong simonhong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonhong @kjozwiak