Add config option for webcompat reporter API endpoint #6550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 tasks
f8f4038 to
18df780
Compare
18df780 to
5cea144
Compare
5cea144 to
0268a0b
Compare
0268a0b to
2c9c40e
Compare
bridiver
approved these changes
Nov 27, 2019
bridiver
reviewed
Nov 27, 2019
| @@ -58,6 +58,7 @@ const Config = function () { | |||
| this.braveServicesKey = getNPMConfig(['brave_services_key']) || '' | |||
| this.infuraProjectId = getNPMConfig(['brave_infura_project_id']) || '' | |||
| this.safeBrowsingApiEndpoint = getNPMConfig(['safe_browsing_api_endpoint']) || 'safebrowsing.brave.com' | |||
| this.webcompatReportApiEndpoint = getNPMConfig(['webcompat_report_api_endpoint']) || 'https://webcompat.brave.com/1/webcompat' | |||
There was a problem hiding this comment.
we really should be moving these default values into gn because webcompat_report_api_endpoint = "" would crash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for brave/brave-core#3420