Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable use_jumbo_build for now #412

Merged
merged 1 commit into from
Jun 23, 2018
Merged

Disable use_jumbo_build for now #412

merged 1 commit into from
Jun 23, 2018

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Jun 22, 2018

Example: widevine_cmdm_compoennt_installer.cc is included in a generated jumbo .cc file via a relative path.

Fix #411

It will be re-added eventually in #410

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions

Example: widevine_cmdm_compoennt_installer.cc is included in a generated jumbo .cc file via a relative path.

Fix #411

It will be re-added eventually in #410
@bbondy bbondy self-assigned this Jun 22, 2018
@bbondy bbondy requested a review from simonhong June 22, 2018 21:20
Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks!

@bbondy bbondy merged commit 80614db into master Jun 23, 2018
@cezaraugusto cezaraugusto deleted the jumbo-build branch July 9, 2018 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants