-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard claim promotion from the UI #9662
Comments
@NejcZdovc brave/brave-core#5485 - we cannot execute step 4 (solve captcha) and step 5 (make sure that you see an error and status stays at 1). After changing |
@GeetaSarvadnya do not restart browser, change value in db while browser is still running |
Verification passed on
Verification passed on
Verified test plan from brave/brave-core#5485
Verification PASSED on
|
Right now if UI for some reason doesn't clear the claim button user could click on it twice which could override privacy pass data from the first click. To prevent this we should put guard in place in function
Promotion::Claim
(which is called from the UI, so that we check if promotion is already in progress we should exit so that we don't override any data. Retry logic will take over if something goes wrongThe text was updated successfully, but these errors were encountered: