Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add promotions info to rewards internals page #9527

Closed
NejcZdovc opened this issue Apr 29, 2020 · 1 comment · Fixed by brave/brave-core#5416
Closed

Add promotions info to rewards internals page #9527

NejcZdovc opened this issue Apr 29, 2020 · 1 comment · Fixed by brave/brave-core#5416

Comments

@NejcZdovc
Copy link
Contributor

We should add claimed promotions to internals page. We should also display how much BAT for each promotions is left.

@btlechowski
Copy link

btlechowski commented Jun 2, 2020

Verification passed on

Brave 1.10.79 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
Revision 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS Ubuntu 18.04 LTS

Verified test plan from the description
Verified Promotions section is present in brave://rewards-internals. Verified promotions are properly displayed
image

Verification passed on

Brave | 1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

  • Claimed UGP grants (Promotion1 and Promotion 2) and verified Rewards info is displayed as expected

image

  • Performed AC and set recurring tips and sent on-time tips to verified pubs and ensured that the brave://rewards-internal page values updated accordingly.
  • Verified wallet balance and the balance shown in rewards internal page is intact
    image

Verified passed with

Brave | 1.10.80 Chromium: 81.0.4044.138 (Official Build) dev (64-bit)
-- | --
Revision | 8c6c7ba89cc9453625af54f11fd83179e23450fa-refs/branch-heads/4044@{#999}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Confirmed Balance info and Promotions sections on brave://rewards-internals page:

Screen Shot 2020-06-02 at 9 13 26 AM

  • Confirmed Balance info sums as expected and shows breakdown of BAT as expected:

Screen Shot 2020-06-02 at 9 14 23 AM

  • Confirmed Promotions (UGP and Ad grants) only show claim info once they have been claimed in the UI:

Screen Shot 2020-06-02 at 9 16 34 AM

  • Confirmed tipping and AC cause expected BAT to decrease (Rewards BAT first since that is available)

@rebron rebron changed the title Add promotion info to rewards internals page Add promotions info to rewards internals page Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment