Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import Extensions from Chrome using importer and brave://welcome onboarding #7974

Closed
bsclifton opened this issue Jan 29, 2020 · 2 comments · Fixed by brave/brave-core#4672
Closed

Import Extensions from Chrome using importer and brave://welcome onboarding #7974

bsclifton opened this issue Jan 29, 2020 · 2 comments · Fixed by brave/brave-core#4672
Assignees
@simonhong
Labels
feature/importer feature-request priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.8.x - Release

Comments

@bsclifton
Copy link
Member

Description

Users are able to import from Chrome, Firefox, Edge, Safari (options can depend on their platform).

They can import bookmarks, passwords, etc. But there is currently no way to import extensions and extension settings

Offering this would be a great way to make Brave easier to switch to

Steps to Reproduce

  1. Use Chrome and have a few extensions, each which may have a specific config
  2. Launch Brave and go to import

Actual result:

No way to import extensions ☹️

Expected result:

You should be able to import extensions
@simonhong simonhong self-assigned this Feb 17, 2020
@simonhong
Copy link
Member

simonhong commented Feb 18, 2020 •
edited
Loading

I think chromium's extension sync logic could be helpful because chrome is syncing extension list and it installs synced list in background. After getting extensions list from chrome's user dir, install logic could be reused. Or it can give some clues to this task done easily.

@simonhong simonhong mentioned this issue Feb 18, 2020
Merged
32 tasks
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 18, 2020
@simonhong simonhong added this to the 1.7.x - Nightly milestone Feb 20, 2020
simonhong added a commit to brave/brave-core that referenced this issue Feb 21, 2020
@simonhong
Enable extensions importing from Chrome
b745698 
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

NOTE: this commits has many cleanup changes around importing area
that uses deprecated patching style.

fix brave/brave-browser#7974
bsclifton pushed a commit to brave/brave-core that referenced this issue Feb 24, 2020
@simonhong @bsclifton
Enable extensions importing from Chrome
38bd853 
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

NOTE: this commits has many cleanup changes around importing area
that uses deprecated patching style.

fix brave/brave-browser#7974
simonhong added a commit to brave/brave-core that referenced this issue Mar 5, 2020
@simonhong
Enable extensions importing from Chrome
5fdf736 
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

NOTE: this commits has many cleanup changes around importing area
that uses deprecated patching style.

fix brave/brave-browser#7974
simonhong added a commit to brave/brave-core that referenced this issue Mar 17, 2020
@simonhong
Enable extensions importing from Chrome
553a3c0 
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

NOTE: this commits has many cleanup changes around importing area
that uses deprecated patching style.

fix brave/brave-browser#7974
simonhong added a commit to brave/brave-core that referenced this issue Mar 23, 2020
@simonhong
Enable extensions importing from Chrome
044b443 
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

NOTE: this commits has many cleanup changes around importing area
that uses deprecated patching style.

fix brave/brave-browser#7974
@bsclifton bsclifton mentioned this issue Mar 24, 2020
Closed
simonhong added a commit to brave/brave-core that referenced this issue Mar 25, 2020
@simonhong
Enable extensions importing from Chrome
1507334 
BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

BraveExternalProcessImporterHost will fetch available extensions list
and ask to install them.
Other importing options are done via other utility process but
importing extension should be done in browser process.
So, BraveExternalProcessImporterHost manages extension installs.

NOTE: this commits has many cleanup changes around importing area
that uses deprecated patching style.

fix brave/brave-browser#7974
@rebron rebron added the QA/Yes label Mar 31, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Apr 22, 2020 •
edited by btlechowski
Loading

Verified passed on macOS Mojave 10.14.6 with

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-04-22 at 12 08 11 PM

  • Confirmed if at least one extension is installed on Chrome the 'Extensions' checkbox does display on brave://settings/importData

Screen Shot 2020-04-22 at 12 09 27 PM

  • Confirmed able to import extensions from Chrome using:

    • direct navigation to brave://settings/importData
    • brave://welcome import slide
    • navigating to brave://settings and selecting 'Import bookmarks and settings' (opens brave://settings/importData)
    • hamburger menu > Bookmarks > Import Bookmarks and Settings (opens brave://settings/importData)
    • (macOS only) file menu > Brave > Import Bookmarks and Settings (opens brave://settings/importData)

  • Confirmed navigating to brave://extensions shows the imported extensions

  • Confirmed able to remove imported extensions

  • Confirmed able to interact with imported extensions

  • Confirmed able to add new extensions after import

Tested using: Honey, Grammarly

Note - state is not persisted (must re-log in to all extensions), confirmed with @bsclifton. This will be covered by a separate issue #8847.

Verified passed on macOS High Sierra 10.13.6 with

Brave 1.8.82 Chromium: 81.0.4044.113 (Official Build) dev (64-bit)
Revision e3225dafb0475864a1812a374d73a92e391635ac-refs/branch-heads/4044@{#936}
OS macOS Version 10.13.6 (Build 17G12034)
  • Quick checks of importing extensions on High Sierra worked as expected.
  • Confirmed extensions imported, able to remove/interact with imported extensions.

Verification PASSED on macOS 10.15.4 x64 using the following build:

Brave | 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
-- | --
Revision | 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS | macOS Version 10.15.4 (Build 19E287)
  • ensured that you can import extensions via both brave://settings/importData and brave://welcome
    • ensured that Extensions is selected if Chrome has installed extenstions
    • ensured that Extensions isn't selected if Chrome doesn't have any extensions installed
  • ensured that the imported extensions are listed under brave://extensions/
  • ensured that you can use/login into an important extension (LastPass in this instance)
  • ensured that you can remove an imported extension via brave://extensions/
  • ensured that you can remove an imported extension by right clicking on the extension icon next to the hamburger menu and selecting Remove from Brave
  • ensured that you can reinstall an extension that was imported and removed

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)

  • Verified test plan from Import chrome extension list brave-core#4672

  • Confirmed if no extensions are installed on Chrome the 'Extensions' checkbox does not display on brave://settings/importData
    image

  • Confirmed if at least one extension is installed on Chrome the 'Extensions' checkbox does display on brave://settings/importData
    image

  • Confirmed able to import extensions from Chrome using:

    • direct navigation to brave://settings/importData
    • brave://welcome import slide
    • navigating to brave://settings and selecting 'Import bookmarks and settings' (opens brave://settings/importData)
    • hamburger menu > Bookmarks > Import Bookmarks and Settings (opens brave://settings/importData)

Tested using: Honey, Grammarly, Lastpass, Pocket, google translate

Verification passed on

Brave 1.8.85 Chromium: 81.0.4044.122 (Official Build) (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Ubuntu 18.04 LTS

  • Verified test plan from Import chrome extension list brave-core#4672

  • Confirmed if no extensions are installed on Chrome the 'Extensions' checkbox does not display on brave://settings/importData
    image
    image

  • Confirmed if at least one extension is installed on Chrome the 'Extensions' checkbox does display on brave://settings/importData

  • Confirmed able to import extensions from Chrome using:

    • direct navigation to brave://settings/importData
    • brave://welcome import slide
    • navigating to brave://settings and selecting 'Import bookmarks and settings' (opens brave://settings/importData)
    • hamburger menu > Bookmarks > Import Bookmarks and Settings (opens brave://settings/importData)

  • Confirmed navigating to brave://extensions shows the imported extensions

  • Confirmed able to remove imported extensions

  • Confirmed able to interact with imported extensions

  • Confirmed able to add new extensions after import

@LaurenWags LaurenWags mentioned this issue Apr 28, 2020
Closed
@rebron rebron changed the title Users should be able to import Extensions Import Extensions from Chrome using importer and brave://welcome onboarding Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
feature/importer feature-request priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.8.x - Release
Development

Successfully merging a pull request may close this issue.

Import chrome extension list brave/brave-core
7 participants
@kjozwiak @bsclifton @rebron @simonhong @LaurenWags @btlechowski @GeetaSarvadnya