-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "Device recognition" label to "Fingerprint" #7949
Change "Device recognition" label to "Fingerprint" #7949
Comments
@cezaraugusto is this something you'd be able to look at? 😄 |
Close brave/brave-browser#7949 Areas changed by this commit are Shields settings and Shields panel
Fingerprint is a super overloaded term, even for the very very small number of folks who know web privacy terms. I think “device fingerprinting” is better than fingerprinting, but I also think we should probably just get rid of this setting all together, as we move to farbling (i.e. fingerprinting protections we have high confidence will not break things) |
Close brave/brave-browser#7949 Areas changed by this commit are Shields settings and Shields panel
Verification passed on
|
@GeetaSarvadnya @bsclifton It should be "fingerprinting" not "fingerprinting attempts", so the options should be this: |
Milestone updated per brave/brave-core#5140 addressing extra feedback per #7949 (comment) |
Clearing |
@karenkliu can you take a look at this one please? It looks like but still exists in two of the options on the panel (it's in the middle of the strings) Is this ok? afaik there are changes coming to Fingerprinting and its labels - not sure when that is though. |
@LaurenWags "Attempts" need to be removed from all the fingerprinting options. I already addressed this in the comment here #7949 (comment) The options should be this for both Shields panel and brave://settings/shields: |
Verified passed with
Verification passed on
Upgrade Profile Upgraded 1.7.x to 1.8.x and verified that the Global fingerprint setting changed from Verification passed on
|
Device recognition
as Fingerprint
Device recognition
label to Fingerprint
Device recognition
label to Fingerprint
Test plan
See brave/brave-core#4574
Description
The term "Fingerprinting" is becoming more mainstream. We'd like to change all references for
Device recognition
toFingerprint
As an example:
Cross-site device recognition blocked
=>Cross-site fingerprint blocked
Let's confirm all uses with @karenkliu, @tomlowenthal, @diracdeltas, and others before closing ticket
Miscellaneous Information:
Original issue where we changed things to
device recognition
: #3027The text was updated successfully, but these errors were encountered: