Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do string transformations which are not idempotent only once #646

Closed
bbondy opened this issue Jul 26, 2018 · 0 comments
Closed

Do string transformations which are not idempotent only once #646

bbondy opened this issue Jul 26, 2018 · 0 comments
Assignees
@bbondy
Labels
QA/No
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Jul 26, 2018

lib/l10nUtil.js does some transformations on strings which if applied more than once consecutively causes infinitely changing output. Changes should be via XML manipulations which are idempotent instead.
@bbondy bbondy added this to the Releasable builds milestone Jul 26, 2018
@bbondy bbondy self-assigned this Jul 26, 2018
bbondy added a commit that referenced this issue Jul 26, 2018
@bbondy
Mark all strings for l10n
b99afd3 
Fix #645
Fix #646
Fix #475

Also calls out to upload missing strings
This was referenced Jul 26, 2018
Merged
Merged
@bbondy bbondy added the QA/No label Aug 18, 2018
petemill pushed a commit to brave/brave-core that referenced this issue Jul 27, 2020
@bbondy
Mark all strings for l10n
8706d81 
Fix brave/brave-browser#645
Fix brave/brave-browser#646
Fix brave/brave-browser#475

Also calls out to upload missing strings
petemill pushed a commit to brave/brave-core that referenced this issue Jul 28, 2020
@bbondy
Mark all strings for l10n
ac2fd08 
Fix brave/brave-browser#645
Fix brave/brave-browser#646
Fix brave/brave-browser#475

Also calls out to upload missing strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

No branches or pull requests
1 participant
@bbondy