Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Designated balance call #4945

Closed
NejcZdovc opened this issue Jun 16, 2019 · 1 comment · Fixed by brave/brave-core#2715
Closed

Designated balance call #4945

NejcZdovc opened this issue Jun 16, 2019 · 1 comment · Fixed by brave/brave-core#2715

Comments

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 16, 2019

Currently we are getting balance based on wallet properties that we are getting them from the server. With Gemini we need to handle multiple wallets meaning that we need to have designated call to get balance which will combine wallet properties with other wallet balances. In this phase we should just prepare this call with returning balance from wallet properties only.

We need to remove balance and rates from wallet properties so that people would not use old API anymore.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jul 30, 2019

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants