Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search promotion button in omnibox #40776

Closed
3 of 6 tasks
simonhong opened this issue Aug 30, 2024 · 5 comments · Fixed by brave/brave-core#25409
Closed
3 of 6 tasks

Add search promotion button in omnibox #40776

simonhong opened this issue Aug 30, 2024 · 5 comments · Fixed by brave/brave-core#25409
Assignees
@simonhong
Labels
Brave Search feature/search OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.73.x - Release

Comments

@simonhong
Copy link
Member

simonhong commented Aug 30, 2024 •
edited
Loading

Description

Screenshot 2024-08-30 at 10 28 51 AM

Steps to reproduce

NOTE: This feature will be controlled via griffin.
To test easily w/o griffin, we could launch browser with --enable-features=BraveSearchPromotionOmniboxButton cmd args

  1. Launch browser with clean profile and with additional cmd args mentioned above note
  2. Set DDG as a default search provider
  3. Type any keyword and check promotion button is shown like above screenshot
  4. Change to brave search as a default search provider
  5. Type any keyword and check promotion button is not shown
  6. Set DDG as a default search provider and type anything
  7. Click the promotion button and check brave search page with typed query is loaded
  8. Check default browser is changed to brave search
  9. If x button is clicked after step above step 3, button will not be shown again and provider is also not changed
  10. If just click enter after typing at step 3, DDG page is shown and promotion button will be shown again

Actual result

N/A

Expected result

See the STR

Reproduces how often

Easily reproduced

Brave version (brave://version info)

n/a

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @rebron @brave/qa-team
@simonhong simonhong self-assigned this Aug 30, 2024
@simonhong
Copy link
Member Author

@rebron This button promotion also should be controlled by griffin?

simonhong added a commit to brave/brave-core that referenced this issue Sep 3, 2024
@simonhong
Added search promotion button in omnibox
d2b6c09 
fix brave/brave-browser#40776
@simonhong simonhong mentioned this issue Sep 3, 2024
Merged
24 tasks
simonhong added a commit to brave/brave-core that referenced this issue Sep 4, 2024
@simonhong
Added search promotion button in omnibox
1f64210 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 4, 2024
@simonhong
Added search promotion button in omnibox
84d86be 
fix brave/brave-browser#40776
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Sep 4, 2024
@rebron rebron added this to General Sep 4, 2024
@rebron rebron moved this to In progress in General Sep 4, 2024
simonhong added a commit to brave/brave-core that referenced this issue Sep 5, 2024
@simonhong
Added search promotion button in omnibox
0a95238 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 5, 2024
@simonhong
Added search promotion button in omnibox
a116f33 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 6, 2024
@simonhong
Added search promotion button in omnibox
ef5455a 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 9, 2024
@simonhong
Added search promotion button in omnibox
4ddea0a 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 9, 2024
@simonhong
Added search promotion button in omnibox
1474caa 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 9, 2024
@simonhong
Added search promotion button in omnibox
d833ae3 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 10, 2024
@simonhong
Added search promotion button in omnibox
ba24936 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 10, 2024
@simonhong
Added search promotion button in omnibox
1ea573f 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 11, 2024
@simonhong
Added search promotion button in omnibox
cad4c85 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 11, 2024
@simonhong
Added search promotion button in omnibox
bf2c6ad 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 11, 2024
@simonhong
Added search promotion button in omnibox
d027e36 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 12, 2024
@simonhong
Added search promotion button in omnibox
dabd40f 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 12, 2024
@simonhong
Added search promotion button in omnibox
4586a2f 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 12, 2024
@simonhong
Added search promotion button in omnibox
d06f456 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 13, 2024
@simonhong
Added search promotion button in omnibox
218f4a3 
fix brave/brave-browser#40776
simonhong added a commit to brave/brave-core that referenced this issue Sep 14, 2024
@simonhong
Added search promotion button in omnibox
432e061 
fix brave/brave-browser#40776
@github-project-automation github-project-automation bot moved this from In progress to Completed in General Sep 17, 2024
@brave-builds brave-builds added this to the 1.72.x - Nightly milestone Sep 17, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 19, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.72.85 Chromium: 130.0.6723.58 (Official Build) beta (64-bit)
-- | --
Revision | 2c872aa4d2694bc73ec58e3b14538a4008a6381e
OS | Windows 11 Version 23H2 (Build 22631.4317)
Case 1: New Profile - `Switch to Brave Search` button - PASSED
  1. Installed 1.72.85
  2. launched Brave with args --enable-features=BraveSearchPromotionOmniboxButton
  3. opened brave://settings/search in a new tab
  4. clicked Change button
  5. selected DuckDuckGo and clicked Set as defaut
  6. verified DuckDuckGo for Normal window in the brave://settings/search
  7. open a new tab and typed Hall
  8. confirmed search promotion button Switch to Brave Search in the omnibox
  9. returned to brave://settings/search
  10. clicked Change and switched to Brave SE
  11. opened a new tab and type Hall
  12. confirmed Switch to Brave Search promotion button in the omnibox is not shown
  13. returned to brave://settings/search and switched to DDG SE
  14. opened a new tab and typed Hall
  15. clicked Switch to Brave Search button in the omnibox
  16. confirmed Brave search results rendered
  17. closed the tab and typed Hall again
  18. confirmed the search promotion button Switch to Brave Search is not shown
  19. confirmed first entry in the omnibox results show Brave search
  20. returned to brave://settings/search
  21. confirmed Brave is set as a default for Normal window
step 5 step 6 step 8 step 10 step 12 step 13 step 15 step 16 step 19 step 21
Image Image Image Image Image Image Image Image Image Image
Case 2: Dismiss the promotion button - PASSED
  1. Launched new Brave profile (with args --enable-features=BraveSearchPromotionOmniboxButton cmd args)
  2. switched to Dark theme via brave://settings/appearance
  3. opened brave://settings/search
  4. switched to DuckDuckGo
  5. opened a new tab and typed Hall
  6. confirmed search promotion button Switch to Brave Search shown in the omnibox
  7. clicked x to dismiss the button
  8. closed the tab
  9. opened a new tab and typed Hall
  10. confirmed search promotion button is not shown
step 6 step 7 step 10
Image Image Image

@MadhaviSeelam MadhaviSeelam added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 19, 2024
@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 1, 2024 •
edited
Loading

Verification PASSED using

Brave | 1.72.93 Chromium: 131.0.6778.14 (Official Build) beta (arm64)
-- | --
Revision | 69e5dc20ca483a13316632df5bcd9279bb2a3cb7
OS | macOS Version 14.6.1 (Build 23G93)
Case 1: New Profile - `Switch to Brave Search` button - PASSED
  1. Installed 1.72.93
  2. launched Brave with args --enable-features=BraveSearchPromotionOmniboxButton cmd args
  3. opened brave://settings/search in a new tab
  4. clicked Change button
  5. selected DuckDuckGo and clicked Set as defaut
  6. verified DuckDuckGo for Normal window in the brave://settings/search
  7. open a new tab and typed Diwali
  8. confirmed search promotion button Switch to Brave Search in the omnibox
  9. returned to brave://settings/search
  10. clicked Change and switched to Brave SE
  11. opened a new tab and type Diwali
  12. confirmed Switch to Brave Search promotion button in the omnibox is not shown
  13. returned to brave://settings/search and switched to DDG SE
  14. opened a new tab and typed Diwali
  15. clicked Switch to Brave Search button in the omnibox
  16. confirmed Brave search results rendered
  17. closed the tab and typed Diwali again
  18. confirmed the search promotion button Switch to Brave Search is not shown
  19. confirmed first entry in the omnibox results show Brave search
  20. returned to brave://settings/search
  21. confirmed Brave is set as a default for Normal window
step 5 step 6 step 8 step 10 step 12 step 13 step 15 step 16 step 19 step 21
Image Image Image Image Image Image Image Image Image Image
Case 2: Dismiss the promotion button - PASSED
  1. Launched new Brave profile (with args --enable-features=BraveSearchPromotionOmniboxButton)
  2. switched to Dark theme via brave://settings/appearance
  3. opened brave://settings/search
  4. switched to DuckDuckGo
  5. opened a new tab and typed Diwali
  6. confirmed search promotion button Switch to Brave Search shown in the omnibox
  7. clicked x to dismiss the button
  8. closed the tab
  9. opened a new tab and typed Diwali
  10. confirmed search promotion button is not shown
step 4 step 6 step 7 step 10
Image Image Image Image

@MadhaviSeelam
Copy link

MadhaviSeelam commented Nov 6, 2024 •
edited
Loading

Verification PASSED using

Brave	1.72.95 Chromium: 131.0.6778.24 (Official Build) beta (64-bit) 
Revision	006619fbaf6013cb3495b90fc3885eda343087e5
OS	Linux
Case 1: New Profile - Switch to Brave Search button - PASSED
  1. Installed 1.72.95
  2. launched Brave with args --enable-features=BraveSearchPromotionOmniboxButton
  3. opened brave://settings/search in a new tab
  4. clicked Change button
  5. selected DuckDuckGo and clicked Set as defaut
  6. verified DuckDuckGo for Normal window in the brave://settings/search
  7. open a new tab and typed elections
  8. confirmed search promotion button Switch to Brave Search in the omnibox
  9. returned to brave://settings/search
  10. clicked Change and switched to Brave SE
  11. opened a new tab and type elections
  12. confirmed Switch to Brave Search promotion button in the omnibox is not shown
  13. returned to brave://settings/search and switched to DDG SE
  14. opened a new tab and typed elections
  15. clicked Switch to Brave Search button in the omnibox
  16. confirmed Brave search results rendered
  17. closed the tab and typed elections again
  18. confirmed the search promotion button Switch to Brave Search is not shown
  19. confirmed first entry in the omnibox results show Brave search
  20. returned to brave://settings/search
  21. confirmed Brave is set as a default for Normal window
step 5 step 6 step 8 step 10 step 12 step 13 step 15 step 16 step 19 step 21
Image Image Image Image Image Image Image Image Image Image
Case 2: Dismiss the promotion button - PASSED
  1. Launched new Brave profile (with args --enable-features=BraveSearchPromotionOmniboxButton cmd args)
  2. switched to Light theme via brave://settings/appearance
  3. opened brave://settings/search
  4. switched to DuckDuckGo
  5. opened a new tab and typed elections
  6. confirmed search promotion button Switch to Brave Search shown in the omnibox
  7. clicked x to dismiss the button
  8. closed the tab
  9. opened a new tab and typed elections
  10. confirmed search promotion button is not shown
step 6 step 7 step 10
Image Image Image

@LaurenWags LaurenWags mentioned this issue Nov 11, 2024
Closed
@LaurenWags
Copy link
Member

Changed to release-notes/exclude per discussion with @rebron

@simonhong simonhong mentioned this issue Dec 6, 2024
Merged
github-merge-queue bot pushed a commit to brave/brave-variations that referenced this issue Jan 17, 2025
@simonhong
Enabled brave search promotion button study for CA/GB in beta/nightly (…
daf6d93 
…#1275)

Related issue - brave/brave-browser#40776

also removed CA/GB from search promotion banner study.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
Brave Search feature/search OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
General
Status: Completed
Milestone
1.73.x - Release
Development

Successfully merging a pull request may close this issue.

Added search promotion button in omnibox brave/brave-core
5 participants
@rebron @simonhong @LaurenWags @brave-builds @MadhaviSeelam