Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show tab search button toggle doesn't work when in vertical-tabs mode #32919

Open
stephendonner opened this issue Sep 11, 2023 · 4 comments
Open

Show tab search button toggle doesn't work when in vertical-tabs mode #32919

stephendonner opened this issue Sep 11, 2023 · 4 comments
Labels
bug feature/vertical-tabs needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop OS/macOS QA/Yes

Comments

@stephendonner
Copy link

stephendonner commented Sep 11, 2023 •
edited
Loading

Description

Show tab search button toggle doesn't work when in vertical-tabs mode

Sadly, found while testing #32809 (maybe/hopefully this is macOS-only?)

Steps to Reproduce

  1. install 1.60.11
  2. launch Brave
  3. context-click on any tab
  4. choose Use Vertical Tabs
  5. open brave://settings/appearance
  6. click to (try to) toggle Show tab search button

Actual result:

Sometimes, nothing seemingly happens; other times, the toggle appears to work but doesn't

show-tab-search

Expected result:

Reproduces how often:

100%

Brave version (brave://version info)

Brave | 1.60.11 Chromium: 117.0.5938.48 (Official Build) nightly (x86_64)
-- | --
Revision | 31e5a6923b9af06a63afc70bd2907933cfd26df7
OS | macOS Version 11.7.9 (Build 20G1426)

Version/Channel Information:

  • Can you reproduce this issue with the current release? TBD
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @sangwoo108 @fallaciousreasoning @rebron @brave/qa-team
@stephendonner
Copy link
Author

Also reproduces with

Brave | 1.58.120 Chromium: 117.0.5938.48 (Official Build) (x86_64)
-- | --
Revision | 8b2e2785c90c076fc1413acb2c003e603eac02d3
OS | macOS Version 11.7.9 (Build 20G1426)

@stephendonner
Copy link
Author

stephendonner commented Sep 11, 2023 •
edited
Loading

Yeah, this appears to be macOS-only (phew), based on my initial testing of 1.60.11 on Windows 10, x64.

Also reproduces on

Brave | 1.57.62 Chromium: 116.0.5845.180 (Official Build) (x86_64)
-- | --
Revision | 77ae816289bb4557b7e04b3ff2e52d091ab68d66
OS | macOS Version 11.7.9 (Build 20G1426)

@stephendonner stephendonner mentioned this issue Sep 11, 2023
Closed
@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Sep 11, 2023
@MadhaviSeelam
Copy link

Reproduced the issue in Linux in 1.58.120 Chromium: 117.0.5938.48. Tab search button is shown and the Search bubble is shown even when Show tab search button is disabled

image (1)

@stephendonner stephendonner mentioned this issue Nov 1, 2023
Closed
@sangwoo108
Copy link

https://bravesoftware.slack.com/archives/C01EVLWS8R5/p1694466274375489

Still we haven't come to the conclusion if we should apply the pref to the vertical tab strip too.

@sangwoo108 sangwoo108 added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Nov 6, 2023
@rebron rebron added this to General May 28, 2024
@rebron rebron moved this to Untriaged Backlog in General May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug feature/vertical-tabs needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop OS/macOS QA/Yes
Projects
General
Status: Untriaged Backlog
Milestone
No milestone
Development

No branches or pull requests
4 participants
@stephendonner @sangwoo108 @rebron @MadhaviSeelam