Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 117.0.5938.35 to Chromium 117.0.5938.48. #32809

Closed
mkarolin opened this issue Sep 6, 2023 · 7 comments · Fixed by brave/brave-core#20030
Closed

Upgrade from Chromium 117.0.5938.35 to Chromium 117.0.5938.48. #32809

mkarolin opened this issue Sep 6, 2023 · 7 comments · Fixed by brave/brave-core#20030
Assignees
@mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA/Test-All-Device-Types QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Milestone
1.58.x - Release

Comments

@mkarolin
Copy link
Contributor

mkarolin commented Sep 6, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/117.0.5938.35..117.0.5938.48?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@mkarolin mkarolin added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Sep 6, 2023
@mkarolin mkarolin self-assigned this Sep 6, 2023
This was referenced Sep 6, 2023
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Sep 7, 2023

The above will need to be verified on 1.58.x once we get C117 merged into 1.58.x. However, it's possible we'll have a higher version at that point so the above will become QA/No. Adding QA/Blocked till C117 moves into 1.58.x.

@mkarolin mkarolin mentioned this issue Sep 7, 2023
Merged
25 tasks
@kjozwiak kjozwiak mentioned this issue Sep 11, 2023
Closed
@kjozwiak
Copy link
Member

Quick overview of the work remaining re: affected areas due to C117 on the following platforms:

Platforms that only require a spot check due to already completing full check of the affected areas mentioned via #31768 (comment):

Platforms that still need to check/verify the affected areas due to C117 changes as per #31768 (comment).

  • Android Tablet - affected areas still need to be checked/verified that they haven't regressed
  • macOS - affected areas still need to be checked/verified that they haven't regressed
  • Linux - affected areas still need to be checked/verified that they haven't regressed

@LaurenWags
Copy link
Member

LaurenWags commented Sep 11, 2023 •
edited
Loading

Verified with

Brave | 1.58.120 Chromium: 117.0.5938.48 (Official Build) (x86_64)
-- | --
Revision | 8b2e2785c90c076fc1413acb2c003e603eac02d3
OS | macOS Version 13.5.2 (Build 22G91)

Verified desktop affected areas from #31768 (comment).

Private/Tor/Guest windows have correct colors - PASSED

Confirmed Brave color schemes for:

  • normal {Dark, Light}
  • Private
  • Tor
  • Guest windows
Normal, Light Normal, Dark Private Tor Guest
1 2 3 4 5

Autocomplete in URL bar generally works as expected - PASSED

  1. Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
  2. Open a new tab and enter the string Buzz in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list
  3. Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
  4. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
  5. Open the buzzfeed.com in any tab
  6. Keep the Top sites still disabled/unchecked
  7. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the Browsing History list
  8. Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 6
  9. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
  10. Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab
  11. Keep the brave://settings/appearance setting as it is
  12. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
  13. Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
  14. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
  15. Enable alll the 3 switches under Show autocomplete suggestions in address bar main switch
  16. Disable the main switch Show autocomplete suggestions in address bar
  17. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF
step 1 step 2 step 3 step 4 step 7 step 8 step 9 step 10 step 11 step 12 step 13 step 14 step 15 step 16 step 17
1 2 3 4 7 8 9 10 11 12 13 14 15 16 17

Confirmed autocomplete provided search suggestions when Improve search suggestions is set to Enabled / On

brave://settings/search improve search suggestions
1 2

Confirmed autocomplete did not provide search suggestions when Improve search suggestions is set to Disabled / Off

brave://settings/search improve search suggestions
3 4

Tab strip has expected colors and geometry - PASSED

Horizontal

1.57.62 1.58.120
1 2
3 4

Vertical

1.57.62 1.58.120
5 6
7 8

Browsing data removal generally works - PASSED

Basic - PASSED

Clear browsing data dialog Browsing history Cookies and other site data Cached images and files
1 2 3 N/A

Advanced - PASSED

Clear browsing data dialog Browsing history Download history Cookies and other site data Passwords Autofill data
1 2 3 4 5 6

On exit - PASSED

Clear browsing data dialog Browsing history Download history Cookies and other site data Passwords Autofill data
1 2 3 4 5 6

Page Info UI generally works (cookies subpage specifically) - PASSED

Confirmed ability to view and manage cookies via the page-info dialog's submenus

Site Information UI Security Site Settings Manage cookies and site data Cookies and site data cleared data reload prompt logged out
1 2 3 4 5 6 7 8

@stephendonner
Copy link

stephendonner commented Sep 11, 2023 •
edited
Loading

Verification PASSED using

Brave | 1.58.120 Chromium: 117.0.5938.48 (Official Build) (x86_64)
-- | --
Revision | 8b2e2785c90c076fc1413acb2c003e603eac02d3
OS | macOS Version 11.7.9 (Build 20G1426)

Tab search looks and functions as expected - PASSED (*)

Default-tab type

Show tab search button enabled Show tab search button disabled open tabs search
Screen Shot 2023-09-11 at 2 25 13 PM Screen Shot 2023-09-11 at 2 25 21 PM Screen Shot 2023-09-11 at 2 25 29 PM Screen Shot 2023-09-11 at 2 25 34 PM

Vertical-tab type

Show tab search button enabled Show tab search button disabled open tabs search
Screen Shot 2023-09-11 at 2 07 21 PM (*) logged #32919 Screen Shot 2023-09-11 at 2 12 19 PM Screen Shot 2023-09-11 at 2 12 37 PM

Shields generally work correctly (cookies blocked) - PASSED

  1. installled 1.58.120
  2. launched Brave
  3. opened brave://settings/shields
  4. confirmed Trackers & ads blocking was set to Standard
  5. loaded aol.com
  6. clicked on the Shields icon in the address bar
  7. clicked on Advanced controls
  8. confirmed the corresponding cookie-blocking options below

Block all cookies - PASSED

Confirmed all cookies were blocked

example example
Screen Shot 2023-09-11 at 12 31 35 PM Screen Shot 2023-09-11 at 12 32 11 PM

Block cross-site cookies - PASSED

Confirmed all third-party cookies were blocked, but aol.com ones were allowed

example example
Screen Shot 2023-09-11 at 12 28 53 PM Screen Shot 2023-09-11 at 12 29 25 PM

Allow all cookies - PASSED

Confirmed third-party (yahoo.net) cookies were additionally allowed

example example
Screen Shot 2023-09-11 at 12 37 17 PM Screen Shot 2023-09-11 at 12 37 42 PM

HTTP -> HTTPS upgrading works as expected - PASSED

  1. installed 1.58.120
  2. launched Brave
  3. opened brave://settings/shields
  4. confirmed Upgrade connections to HTTPS was Enabled by default
  5. loaded http://upgradable.arthuredelstein.net
  6. enabled Show Full URLs from the top-level View menu

Confirmed I was automatically upgraded to https://upgradable.arthuredelstein.net from http://upgradable.arthuredelstein.net

Also confirmed clicked through the warning interstitial on http://insecure.arthuredelstein.net, which loaded the site. Finally, confirmed Not secure warning in address bar for http://http.badssl.com

example example example example example
Screen Shot 2023-09-11 at 12 05 43 PM Screen Shot 2023-09-11 at 12 08 02 PM Screen Shot 2023-09-11 at 12 10 57 PM Screen Shot 2023-09-11 at 12 11 01 PM Screen Shot 2023-09-11 at 12 11 24 PM

Vertical tabs look and work as expected - PASSED

Steps:

  1. installed 1.58.120
  2. launched Brave
  3. loaded a few tabs
  4. context-clicked on a tab and chose Use Vertical Tabs
  5. confirmed vertical-tab mode
  6. context-clicked on a tab and confirmed context-menu items were tab-specific
  7. confirmed default prefs in brave://settings/appearance
  8. confirmed Show title bar and collapsed view
  9. also confirmed Dark mode
example example example example example example
Screen Shot 2023-09-11 at 11 19 45 AM Screen Shot 2023-09-11 at 11 19 53 AM Screen Shot 2023-09-11 at 11 25 24 AM Screen Shot 2023-09-11 at 11 31 32 AM Screen Shot 2023-09-11 at 11 31 41 AM Screen Shot 2023-09-11 at 11 40 28 AM

Confirmed vertical tabs looked and worked as expected, in both Light and Dark modes

example example example
Screen Shot 2023-09-11 at 11 43 26 AM Screen Shot 2023-09-11 at 11 44 52 AM Screen Shot 2023-09-11 at 11 47 29 AM

Password Manager has expected Brave styling - PASSED

Steps:

  1. installed 1.58.120
  2. launched Brave
  3. opened brave://settings
  4. clicked on Autofill and passwords
  5. clicked Add
  6. added fill.devtest entry
  7. clicked on entry to view it
  8. confirmed I was prompted for my Touch ID
  9. confirmed password details for fill.dev were revealed

Confirmed Brave styling throughout Password Manager, in both Dark and Light modes

Dark

default brave://password-manager/settings Add new password fill.dev entry Touch ID prompt fill.dev details inactivity timeout
Screen Shot 2023-09-11 at 10 32 03 AM Screen Shot 2023-09-11 at 10 34 11 AM Screen Shot 2023-09-11 at 10 36 34 AM Screen Shot 2023-09-11 at 10 36 37 AM Screen Shot 2023-09-11 at 10 37 13 AM Screen Shot 2023-09-11 at 10 36 45 AM Screen Shot 2023-09-11 at 10 42 34 AM

Light

default brave://password-manager/settings Add new password fill.dev entry Touch ID prompt fill.dev details inactivity timeout
Screen Shot 2023-09-11 at 10 45 13 AM Screen Shot 2023-09-11 at 10 47 00 AM Screen Shot 2023-09-11 at 10 45 28 AM Screen Shot 2023-09-11 at 10 44 44 AM Screen Shot 2023-09-11 at 10 45 01 AM Screen Shot 2023-09-11 at 10 45 05 AM Screen Shot 2023-09-11 at 10 50 11 AM

Extensions WebUI has expected Brave styling & extensions can be installed - PASSED

Steps:

  1. installed 1.58.120
  2. launched Brave
  3. opened brave://extensions
  4. installed assorted extensions
  5. disabled an extension
  6. clicked Details on an extension
  7. uninstalled an extension

Confirmed Brave styling throughout brave://extensions, in both Light and Dark modes

Light

example example example example example
Screen Shot 2023-09-11 at 10 10 24 AM Screen Shot 2023-09-11 at 10 13 39 AM Screen Shot 2023-09-11 at 10 16 06 AM Screen Shot 2023-09-11 at 10 16 54 AM Screen Shot 2023-09-11 at 10 16 57 AM

Dark

example example example example
Screen Shot 2023-09-11 at 10 20 17 AM Screen Shot 2023-09-11 at 10 20 27 AM Screen Shot 2023-09-11 at 10 20 36 AM Screen Shot 2023-09-11 at 10 21 23 AM

Logged:

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 using the following version(s):

Brave	1.58.120 Chromium: 117.0.5938.48 (Official Build) (32-bit) 
Revision	8b2e2785c90c076fc1413acb2c003e603eac02d3
OS	Android 13; Build/TP1A.220624.014; 33; REL
  • version bump
  • branding
Example Example
Screenshot 2023-09-11 at 2 11 22 PM Screenshot 2023-09-11 at 2 14 35 PM

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Sep 11, 2023
@MadhaviSeelam
Copy link

MadhaviSeelam commented Sep 11, 2023 •
edited
Loading

Verification PASSED using

Brave	1.58.120 Chromium: 117.0.5938.48 (Official Build) (64-bit) 
Revision	8b2e2785c90c076fc1413acb2c003e603eac02d3
OS	Linux

Verified desktop affected areas from #31768 (comment).

Private/Tor/Guest windows have correct colors - PASSED

Confirmed Brave color schemes for:

  • normal {Dark, Light}
  • Private
  • Tor
  • Guest windows
Normal, Light Normal, Dark Private Tor Guest
image image image image image

Autocomplete in URL bar generally works as expected - PASSED

  1. Confirm that the Show autocomplete suggestions in address bar switch is enabled by default under brave://settings/appearance
  2. Open a new tab and enter the string Buzz in the URL bar and ensured that Buzzfeed.com is in the autocomplete suggestion list
  3. Go to brave://settings/appearance and uncheck/disable the checkbox Top sites
  4. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites toggle is disabled
  5. Open the buzzfeed.com in any tab
  6. Keep the Top sites still disabled/unchecked
  7. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is in the autocomplete suggestion list which is because history is stored due to step 5 and autocomplete suggestion is picked up from the Browsing History list
  8. Go to brave://settings/appearance and uncheck/disable the checkbox Browsing History and keep Top sites as it is in step 6
  9. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites and browsing history toggles are disabled/unchecked
  10. Bookmark the site buzzfeed.com which is already opened in step 5 and close the tab
  11. Keep the brave://settings/appearance setting as it is
  12. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is shown in the autocomplete suggestion list as buzzfeed.com is already bookmarked and autocomplete suggestion is picked up from the Bookmarks list
  13. Go to brave://settings/appearance and uncheck Bookmarks (all the 3 settings checkboxes are unchecked in this step)
  14. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as top sites , browsing history and bookmarks toggles are disabled/unchecked
  15. Enable alll the 3 switches under Show autocomplete suggestions in address bar main switch
  16. Disable the main switch Show autocomplete suggestions in address bar
  17. Open a new tab and enter the string Buzz in the URL bar and ensured that the Buzzfeed.com is NOT in the autocomplete suggestion list as Show autocomplete suggestions in address bar main switch is OFF
step 1 step 2 step 3 step 4 step 7 step 8 step 9 step 10 step 11 step 12 step 13 step 14 step 15 step 16 step 17
image image image image image image image image image image image image image image image

Confirmed autocomplete provided search suggestions when Improve search suggestions is set to Enabled / On

brave://settings/search improve search suggestions
image image

Confirmed autocomplete did not provide search suggestions when Improve search suggestions is set to Disabled / Off

brave://settings/search improve search suggestions
image image

Tab strip has expected colors and geometry - PASSED

Horizontal

1.57.62 1.58.120
image image
image image

Vertical

1.57.62 1.58.120
image image
image image

Browsing data removal generally works - PASSED

Clear browsing data dialog Browsing history Cookies and other site data Cached images and files
image image image N/A

Advanced - PASSED

Clear browsing data dialog Browsing history Download history Cookies and other site data Passwords Autofill data
image image image image image image

On exit - PASSED

Clear browsing data dialog Browsing history Download history Cookies and other site data Passwords Autofill data
image image image image image image

Page Info UI generally works (cookies subpage specifically) - PASSED

Confirmed ability to view and manage cookies via the page-info dialog's submenus

Site Information UI Security Site Settings Manage cookies and site data Cookies and site data cleared data reload prompt logged out
image image image image image image image image

Tab search looks and functions as expected - (PASSED)

Default-tab type

Show tab search button enabled Show tab search button disabled open tabs search
image image image image

Vertical-tab type

Show tab search button enabled Show tab search button disabled open tabs search
image #32919 image image

Shields generally work correctly (cookies blocked) - PASSED

  1. installled 1.58.120
  2. launched Brave
  3. opened brave://settings/shields
  4. confirmed Trackers & ads blocking was set to Standard
  5. selected All in Block cookies
  6. loaded nytimes.com
  7. clicked on the Shields icon in the address bar
  8. clicked on Advanced controls
  9. confirmed the corresponding cookie-blocking options below

Block all cookies - PASSED

Confirmed all cookies were blocked

example example example
image image image

Block cross-site cookies - PASSED

Confirmed all third-party cookies were blocked, but aol.com ones were allowed

example example example
image image image

Allow all cookies - PASSED

Confirmed third-party (abcnewsgo.com) cookies were additionally allowed

example example example
image image image

HTTP -> HTTPS upgrading works as expected - PASSED

  1. installed 1.58.120
  2. launched Brave
  3. opened brave://settings/shields
  4. confirmed Upgrade connections to HTTPS was Enabled by default
  5. loaded http://upgradable.arthuredelstein.net
  6. enabled Show Full URLs from the top-level View menu

Confirmed I was automatically upgraded to https://upgradable.arthuredelstein.net from http://upgradable.arthuredelstein.net

Also confirmed clicked through the warning interstitial on http://insecure.arthuredelstein.net, which loaded the site. Finally, confirmed Not secure warning in address bar for http://http.badssl.com

example example example example
image image image image

Vertical tabs look and work as expected - PASSED

Steps:

  1. installed 1.58.120
  2. launched Brave
  3. loaded a few tabs
  4. context-clicked on a tab and chose Use Vertical Tabs
  5. confirmed vertical-tab mode
  6. context-clicked on a tab and confirmed context-menu items were tab-specific
  7. confirmed default prefs in brave://settings/appearance
  8. confirmed Show title bar and collapsed view
  9. also confirmed Dark mode
example example example example example
image image image image image

Password Manager has expected Brave styling - PASSED

Steps:

  1. installed 1.58.120
  2. launched Brave
  3. opened brave://settings
  4. clicked on Autofill and passwords
  5. clicked Add
  6. added fill.devtest entry
  7. clicked on entry to view it
  8. confirmed I was prompted for my Touch ID
  9. confirmed password details for fill.dev were revealed

Confirmed Brave styling throughout Password Manager, in both Dark and Light modes

Dark

*** Didn't get Password expiry modal

default brave://password-manager/settings Add new password add new pw entry
image image image image

###Light - `Added password via website

save password modal brave://password-manager/settings details
image image image

Extensions WebUI has expected Brave styling & extensions can be installed - PASSED

Steps:

  1. installed 1.58.120
  2. launched Brave
  3. opened brave://extensions
  4. installed assorted extensions
  5. disabled an extension
  6. clicked Details on an extension
  7. uninstalled an extension

Confirmed Brave styling throughout brave://extensions, in both Light and Dark modes

Light

example example example example example
image image image image image
example example example example example example
image image image image image image

@stephendonner stephendonner mentioned this issue Sep 11, 2023
Open
@MadhaviSeelam MadhaviSeelam added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 12, 2023
@kjozwiak
Copy link
Member

Labelling as QA/No & release-notes/exclude in favour of #32945.

@kjozwiak kjozwiak mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA/No QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA/Test-All-Device-Types QA/Test-All-Platforms QA/Test-Plan-Specified release-notes/exclude
Projects
None yet
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 117.0.5938.35 to Chromium 117.0.5938.48. brave/brave-core
7 participants
@stephendonner @kjozwiak @Uni-verse @LaurenWags @mkarolin @brave-builds @MadhaviSeelam