Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Brave VPN toolbar icon for on/off and error states #30410

Closed
rebron opened this issue May 17, 2023 · 4 comments · Fixed by brave/brave-core#18577
Closed

Update Brave VPN toolbar icon for on/off and error states #30410

rebron opened this issue May 17, 2023 · 4 comments · Fixed by brave/brave-core#18577
Assignees
Labels
design A design change, especially one which needs input from the design team feature/vpn misc/icons OS/Desktop OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude

Comments

@rebron
Copy link
Collaborator

rebron commented May 17, 2023

Description

Update the Brave VPN button icons to improve off, on, and error state indication for VPN subscribers.

Design:

Screenshot 2023-05-17 at 10 52 24 AM

https://www.figma.com/file/qtMYwoj3JWJO5xzwLt6j2f/Desktop-VPN?type=design&node-id=1822-19229&t=rbGaXUgJWpgnEvLd-0

Brave version (brave://version info)

tbd

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the nightly channel? n/a

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc: @aguscruiz @stephendonner

@rebron rebron added priority/P2 A bad problem. We might uplift this to the next planned release. misc/icons feature/vpn design A design change, especially one which needs input from the design team release-notes/include QA/Yes labels May 17, 2023
@stephendonner
Copy link

cc @MadhaviSeelam too

@thypon
Copy link
Member

thypon commented May 18, 2023

Nit the red off state might be excessive. Red means:

  • something is broken
  • stop here
  • immediate attention is required

This is ~kinda worldwide universal for anybody who got a driving license.

While urgency may be good, suggesting something is broken in the default state, may be detrimental to the message.

@stephendonner
Copy link

stephendonner commented Jun 9, 2023

Note for @brave/qa-team: parts of the design mockups here (particularly around VPN off states) are slightly outmoded, and are supplanted by the updated ones in #30930 👍 (Leaving QA/Yes for now.)

@stephendonner
Copy link

Marking as QA/No in favor of #30930 (comment) which is where we're verifying these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/vpn misc/icons OS/Desktop OS/macOS OS/Windows priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants