Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NFT works without entering Token ID for Ethereum NFTs #29779

Closed
srirambv opened this issue Apr 17, 2023 · 1 comment
Closed

Add NFT works without entering Token ID for Ethereum NFTs #29779

srirambv opened this issue Apr 17, 2023 · 1 comment
Assignees
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes regression

Comments

@srirambv
Copy link
Contributor

Description

Add NFT works without entering Token ID for Ethereum NFTs

Steps to reproduce

  1. Go to visible asset list and add a custom token
  2. Enter a token address for an NFT
  3. Wait for fields to auto-populate
  4. Add button gets enabled without entering token id
  5. Able to submit the form but no token is added

Actual result

Add.NFT.mp4

Expected result

Add button should only be enabled when token id is entered

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): All
  • Android version: 13

Brave version

1.51.89

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @simoarpe

@srirambv srirambv added bug QA/Yes regression feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/nft labels Apr 17, 2023
@srirambv srirambv added this to Web3 Apr 17, 2023
@HEagle18 HEagle18 added the priority/P3 The next thing for us to work on. It'll ride the trains. label Apr 21, 2023
@HEagle18 HEagle18 moved this to Backlog in Web3 Apr 21, 2023
@simoarpe simoarpe self-assigned this Jul 5, 2024
@simoarpe
Copy link

simoarpe commented Jul 5, 2024

Closing this as not relevant anymore.

@simoarpe simoarpe closed this as completed Jul 5, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Web3 Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes regression
Projects
Archived in project
Development

No branches or pull requests

3 participants