Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Wallet) Add new NFT tab #29274

Closed
simoarpe opened this issue Mar 23, 2023 · 1 comment · Fixed by brave/brave-core#17738
Closed

(Wallet) Add new NFT tab #29274

simoarpe opened this issue Mar 23, 2023 · 1 comment · Fixed by brave/brave-core#17738
Assignees
@simoarpe
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.51.x - Release

Comments

@simoarpe
Copy link

Description

Implements new NFT tab in the Wallet section.
@simoarpe simoarpe added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Mar 23, 2023
@simoarpe simoarpe added this to Web3 Mar 23, 2023
@simoarpe simoarpe mentioned this issue Mar 23, 2023
Merged
25 tasks
@simoarpe simoarpe self-assigned this Mar 23, 2023
@simoarpe simoarpe mentioned this issue Mar 24, 2023
Closed
@github-project-automation github-project-automation bot moved this to Done in Web3 Mar 27, 2023
@brave-builds brave-builds added this to the 1.51.x - Nightly milestone Mar 27, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.51.89 x64 Beta build

  • Verified steps from brave/brave-core#17738
  • Verified on mobile there are only 2 NFTs shown in a row
  • Verified on tablet there are 4 NFT's shown in a row
  • Verified clicking on the NFT shows the details screen
  • Verified able to add NFT from both Edit visible NFTs in NFT tab and Visible asset list from portfolio tab
  • Verified able to add both Ethereum and Solana NFTs
  • Encountered #29779 & 29780
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
29274-ARM.mp4
29274-Tab.mp4

@srirambv srirambv mentioned this issue Apr 17, 2023
Closed
@kjozwiak kjozwiak mentioned this issue May 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51.x - Release
Development

Successfully merging a pull request may close this issue.

Add NFT grid brave/brave-core
3 participants
@simoarpe @srirambv @brave-builds