-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify Purchased step on desktop #29520
Comments
fix brave/brave-browser#29520 RegionData handling will be moved from BraveVpnService to BraveVPNOSConnectionAPI because region data is used when connecting and it's global data cached in local state. As BraveVpnService is per-profile service, it's not fit to handle region data.
fix brave/brave-browser#29520 RegionData handling will be moved from BraveVpnService to BraveVPNOSConnectionAPI because region data is used when connecting and it's global data cached in local state. As BraveVpnService is per-profile service, it's not fit to handle region data.
The above requires |
@simonhong mind giving us a unique testplan for this one? What's written so far in the PR for brave/brave-core#18009 (comment) seems to apply more to #29728. And/or if we already verified #29728 (comment), can that verification apply? Thanks! |
@stephendonner added test plan! 😄 And yes! #29728 (comment) should be perfect |
Verified
|
Brave | 1.51.110 Chromium: 113.0.5672.77 (Official Build) (x86_64) |
---|---|
Revision | c4236862955e005c2187105415ac4a2ecf86dff1-refs/branch-heads/5672_62@{#3} |
OS | macOS Version 13.4 (Build 22F5059b) |
Followed the testplan in #29520 (comment) and covered it via #29728 (comment)
Test plan
Basically make sure happy path is good to go
Description
On desktop, we're waiting to enter
Purchased
status when we have valid region data after getting subscriber credential.We do this because region data is needed to show vpn main panel.
However, region data is not related with purchasing and it makes purchased status handling complex.
Also, because of that we have many
ifdef android
because android doesn't need region data fromBraveVpnService
.To make it more simpler, we could enter
Purchased
state after getting subscriber credential.and region data handling is done by
BraveVPNOSConnectionAPI
.As region data is used for connecting,
BraveVPNOSConnectionAPI
would be good place to manage region data.VPN panel can show sell view when it's not purchased state yet.
and VPN panel can show main view when
BraveVPNOSConnectionAPI
have valid region data.The text was updated successfully, but these errors were encountered: