Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync: rename resetSyncSetupError to clearSyncSetupError #2779

Closed
cezaraugusto opened this issue Jan 2, 2019 · 0 comments · Fixed by brave/brave-core#1193
Closed

Sync: rename resetSyncSetupError to clearSyncSetupError #2779

cezaraugusto opened this issue Jan 2, 2019 · 0 comments · Fixed by brave/brave-core#1193
Assignees
@cezaraugusto
Labels
dev-concern feature/sync QA/No release-notes/exclude
Milestone
0.59.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented Jan 2, 2019 •
edited by bsclifton
Loading

Test plan

See brave/brave-core#1193

Description

@darkdh says it can be confused with resetSync which is a different method and I agree
@cezaraugusto cezaraugusto added this to the 1.x Backlog milestone Jan 2, 2019
@cezaraugusto cezaraugusto self-assigned this Jan 2, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
rename resetSyncSetupError to clearSyncSetupError
0f06363 
close brave/brave-browser#2779
@cezaraugusto cezaraugusto mentioned this issue Jan 2, 2019
Merged
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 2, 2019
@cezaraugusto
rename clearSyncSetupError to clearSyncSetupError
0f8efe3 
close brave/brave-browser#2779
cezaraugusto added a commit to brave/brave-core that referenced this issue Jan 3, 2019
@cezaraugusto
rename clearSyncSetupError to clearSyncSetupError
256aa59 
close brave/brave-browser#2779
@cezaraugusto cezaraugusto modified the milestones: 1.x Backlog, 0.61.x - Nightly Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
dev-concern feature/sync QA/No release-notes/exclude
Projects
None yet
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

fix multiple sync issues brave/brave-core
2 participants
@cezaraugusto @bsclifton