Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Solana support for "The Wallet Standard" #27340

Closed
bbondy opened this issue Dec 13, 2022 · 8 comments · Fixed by brave/brave-core#16412 or brave/brave-core#16724
Closed

Implement Solana support for "The Wallet Standard" #27340

bbondy opened this issue Dec 13, 2022 · 8 comments · Fixed by brave/brave-core#16412 or brave/brave-core#16724

Comments

@bbondy
Copy link
Member

bbondy commented Dec 13, 2022

Implement Solana support for "The Wallet Standard" https://github.com/wallet-standard/wallet-standard support in brave-core

jsx
Hi Brave team 🙂 The Wallet Standard (https://github.com/wallet-standard/wallet-standard) reached 1.0.0 before Breakpoint, and has been stable since. It’s used by many major Solana dapps now (see anza-xyz/wallet-adapter#604 for an incomplete list). There’s an integration guide for wallets (https://github.com/solana-labs/wallet-standard/blob/master/WALLET.md). Since Brave already presents a Phantom-compatible interface, this should be very simple to add. It’s a nonbreaking change (your current interfaces will continue to work exactly as is) and adds no external runtime dependencies. If you integrate this, Brave will show up in the top of the wallet adapter list for all these applications and more. You won’t have to overwrite window.solana or conflict with other wallets. Please let me know if I can help support you!

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Dec 13, 2022
@darkdh darkdh added this to Web3 Dec 16, 2022
@darkdh darkdh self-assigned this Dec 16, 2022
@darkdh darkdh moved this to In Progress in Web3 Dec 16, 2022
@darkdh darkdh added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 16, 2022
@darkdh darkdh moved this from In Progress to In Review in Web3 Dec 19, 2022
Repository owner moved this from In Review to Done in Web3 Dec 22, 2022
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 22, 2022
@LaurenWags LaurenWags added the feature/web3/wallet Integrating Ethereum+ wallet support label Jan 5, 2023
@darkdh darkdh reopened this Jan 17, 2023
@kjozwiak
Copy link
Member

The above requires 1.47.178 or higher for 1.47.x verification 👍

@srirambv
Copy link
Contributor

Verification passed on

Brave 1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Linux
  • Verified steps from brave/brave-core#16724
  • Verified able to submit SignTransaction, SignMessage and SendTransaction
  • Verified legacy transaction is disabled
27340.mp4

Verification passed on

Brave 1.47.181 Chromium: 109.0.5414.87 (Official Build) (64-bit)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16724
  • Verified able to submit SignTransaction, SignMessage and SendTransaction
  • Verified legacy transaction is disabled
27340.mp4

Verification passed on

Brave 1.47.181 Chromium: 109.0.5414.87 (Official Build) (arm64)
Revision 2dc18eb511c56e012081b4abc9e38c81c885f7d4-refs/branch-heads/5414@{#1241}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16724
  • Verified able to submit SignTransaction, SignMessage and SendTransaction
  • Verified legacy transaction is disabled
27340.mov

@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.47.182 x64 build

  • Verified steps from brave/brave-core#16724
  • Verified able to submit SignTransaction, SignMessage and SendTransaction
  • Verified legacy transaction is disabled
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
27340-ARM.mp4
27340-Tab.mp4

@kjozwiak
Copy link
Member

We'll need to recheck this once @darkdh lands a fix that resolves the performance issues mentioned via #27997. @darkdh can you let is know once the performance issues are fixed and the above can be verified? We'll probably uplift the above into 1.47.x as well with the fix.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

Moving this into 1.48.x as we neve received another C109 minor chromium bump that would have triggered another 1.47.x release. We'll leave https://github.com/brave/brave-core/milestone/267 as there's code that landed in 1.47.x but we'll close off the 1.47.x - Release #6 milestone and move all the issues within 1.48.x. The above can be verified with 1.48.156 for 1.48.x.

@kjozwiak kjozwiak modified the milestones: 1.47.x - Release #6, 1.48.x - Release Feb 6, 2023
@kjozwiak
Copy link
Member

kjozwiak commented Feb 6, 2023

@srirambv we'll need to re-run through the above now that #27997 was fixed/merged. Originally it was planned to go out via 1.47.x but looks like we never received a 1.47.x as per #27340 (comment).

I labelled #27997 (comment) as QA/No but if you're running through the above and have some time, can run through the cases that @darkdh mentioned via brave/brave-core#16868 (comment).

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Verification passed on the following devices running 1.47.182 x64 build

  • Verified steps from brave/brave-core#16724
  • Verified able to submit SignTransaction, SignMessage and SendTransaction
  • Verified legacy transaction is disabled
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
27340-ARM.mp4
27340-Tab.mp4

@srirambv
Copy link
Contributor

srirambv commented Feb 6, 2023

Verification passed on

Brave 1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Linux
  • Verified steps from brave/brave-core#16724
  • Verified able to submit SignTransaction, SignMessage and SendTransaction
  • Verified legacy transaction is disabled
27340.mp4

Verification passed on

Brave 1.48.157 Chromium: 110.0.5481.77 (Official Build) (64-bit)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS Windows 11 Version 22H2 (Build 22621.755)
  • Verified steps from brave/brave-core#16724
  • Verified able to submit SignTransaction, SignMessage and SendTransaction
  • Verified legacy transaction is disabled
27340.mp4

Verification passed on

Brave 1.48.157 Chromium: 110.0.5481.77 (Official Build) (arm64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 13.0 (Build 22A380)
  • Verified steps from brave/brave-core#16724
  • Verified able to submit SignTransaction, SignMessage and SendTransaction
  • Verified legacy transaction is disabled
27340.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment