Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR108] Connect to sync chain doesn't show error #26805

Closed
AlexeyBarabash opened this issue Nov 16, 2022 · 4 comments · Fixed by brave/brave-core#15969
Closed

[CR108] Connect to sync chain doesn't show error #26805

AlexeyBarabash opened this issue Nov 16, 2022 · 4 comments · Fixed by brave/brave-core#15969

Comments

@AlexeyBarabash
Copy link
Contributor

Description

After CR108 error while trying connect to the sync chain is not displayed on Desktop

Steps to Reproduce

  1. brave://settings/braveSync/setup => I have a sync code
  2. Enter 23 words, press confirm

Actual result:

  1. The code is not accepted silently

Expected result:

  1. Error text like below

image

Reproduces how often:

Easily

Brave version (brave://version info)

1.47.76 Chromium: 108.0.5359.40 (Developer Build) (64-bit)

Version/Channel Information:

Nightly

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

Works on 1.47.55 Chromium: 107.0.5304.91 (Official Build) unknown (64-bit)

Miscellaneous Information:

@GeetaSarvadnya
Copy link

Reproduced on Windows 10 x64 - 1.47.75

@GeetaSarvadnya
Copy link

The issue doesn't reproduce in Windows 10x64 - 1.47.72 Chromium: 107.0.5304.110 version but it's reproducible in 1.47.75 Chromium: 108.0.5359.40 Looks like CR 108 Chromium bump issue.

image

@LaurenWags LaurenWags changed the title Connect to sync chain doesn't show error [CR108] Connect to sync chain doesn't show error Nov 17, 2022
@mkarolin mkarolin added this to the 1.47.x - Nightly milestone Nov 22, 2022
@LaurenWags
Copy link
Member

Requires 1.46.125 or higher to test

@stephendonner
Copy link

Verified PASSED using

Brave 1.46.126 Chromium: 108.0.5359.48 (Official Build) beta (x86_64)
Revision 18ceeca0d99318e70c00d2e04d88aa55488b5c63-refs/branch-heads/5359@{#854}
OS macOS Version 11.7.1 (Build 20G918)

Steps:

  1. installed 1.46.126
  2. launched Brave
  3. clicked on the "hamburger" menu
  4. clicked Sync
  5. clicked I have a Sync Code
  6. entered various invalid codes
  7. clicked Confirm
  8. clicked OK
  9. confirmed I got This code is invalid
  10. entered in a working code from Brave on iOS
  11. clicked on Confirm
  12. clicked on OK

Confirmed both the initial error for incorrect codes, as well as the working scenario

Example Example Example Example Example Example Example
Screen Shot 2022-11-23 at 2 29 44 PM Screen Shot 2022-11-23 at 2 33 59 PM Screen Shot 2022-11-23 at 2 34 02 PM Screen Shot 2022-11-23 at 2 34 21 PM Screen Shot 2022-11-23 at 2 35 42 PM Screen Shot 2022-11-23 at 2 35 44 PM Screen Shot 2022-11-23 at 2 35 48 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment