Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Toggle has extra couple of blank rows from disabled sync types #2676

Closed
cezaraugusto opened this issue Dec 20, 2018 · 1 comment
Closed

Data Toggle has extra couple of blank rows from disabled sync types #2676

cezaraugusto opened this issue Dec 20, 2018 · 1 comment
Assignees
@cezaraugusto
Labels
design A design change, especially one which needs input from the design team feature/sync QA/No release-notes/exclude
Milestone
0.60.x - Release ...

Comments

@cezaraugusto
Copy link
Contributor

carried over from #2500

setting as QA/no since this is a simple design change with no side-effects
@cezaraugusto cezaraugusto added design A design change, especially one which needs input from the design team feature/sync QA/No release-notes/exclude labels Dec 20, 2018
@cezaraugusto cezaraugusto added this to the 0.60.x - Dev milestone Dec 20, 2018
@cezaraugusto cezaraugusto self-assigned this Dec 20, 2018
@cezaraugusto cezaraugusto mentioned this issue Dec 20, 2018
Closed
cezaraugusto added a commit to brave/brave-ui that referenced this issue Dec 20, 2018
@cezaraugusto
make switch toggle grid with only 1 row
280015b 
address brave/brave-browser#2676
@cezaraugusto cezaraugusto mentioned this issue Dec 20, 2018
Merged
9 tasks
cezaraugusto added a commit to brave/brave-core that referenced this issue Dec 20, 2018
@cezaraugusto
set only 1 row for bookmarks in sync data
98a1412 
fix brave/brave-browser#2676
@cezaraugusto cezaraugusto mentioned this issue Dec 20, 2018
Closed
@NejcZdovc NejcZdovc modified the milestones: 0.60.x - Dev, 1.x Backlog Dec 21, 2018
@cezaraugusto
Copy link
Contributor Author

fix already included in brave-core via brave/brave-core@3dd1294#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R275. closing

@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 2, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Jul 17, 2019
@cezaraugusto
Imported from brave-ui: make switch toggle grid with only 1 row
3cbb0d4 
address brave/brave-browser#2676
cezaraugusto added a commit to brave/brave-core that referenced this issue Aug 1, 2019
@cezaraugusto
Imported from brave-ui: make switch toggle grid with only 1 row
49a726b 
address brave/brave-browser#2676
cezaraugusto added a commit to brave/brave-core that referenced this issue Aug 29, 2019
@cezaraugusto
Imported from brave-ui: make switch toggle grid with only 1 row
2ae667d 
address brave/brave-browser#2676
cezaraugusto added a commit to brave/brave-core that referenced this issue Sep 12, 2019
@cezaraugusto
Imported from brave-ui: make switch toggle grid with only 1 row
e4f7eaf 
address brave/brave-browser#2676
cezaraugusto added a commit to brave/brave-core that referenced this issue Dec 11, 2019
@cezaraugusto
Brave Sync: Imported from brave-ui - make switch toggle grid with onl…
7d31256 
…y 1 row

address brave/brave-browser#2676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cezaraugusto cezaraugusto

Labels
design A design change, especially one which needs input from the design team feature/sync QA/No release-notes/exclude
Projects
None yet
Milestone
0.60.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

set only 1 row for bookmarks in sync data brave/brave-core
2 participants
@cezaraugusto @NejcZdovc