Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icloud.com never loads with default shield settings #2622

Closed
cndouglas opened this issue Dec 18, 2018 · 7 comments · Fixed by brave/referrer-whitelist#2
Closed

icloud.com never loads with default shield settings #2622

cndouglas opened this issue Dec 18, 2018 · 7 comments · Fixed by brave/referrer-whitelist#2
Assignees
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes webcompat/shields Shields is breaking a website.

Comments

@cndouglas
Copy link
Contributor

Description

https://www.icloud.com/ never finishes loading with the default shield settings, as shown below:
image

The site loads correctly with the cookie setting changed to All cookies allowed.

Steps to Reproduce

  1. Start with a fresh profile or reset all content settings.
  2. Go to https://www.icloud.com/

Actual result:

The login page never loads. The following error message appears after a while:

Here is the developer console output (with a few errors):
image

Expected result:

The site should load the login page, like this:

Reproduces how often:

Always

Brave version (brave://version info)

Brave | 0.60.3 Chromium: 71.0.3578.98 (Official Build) dev(64-bit)
Revision | 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS | Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? Yes, 0.60.3 dev.

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? Yes.
  • Is the issue reproducible on the latest version of Chrome? Not sure.

Additional Information

#1025 mentions a problem with icloud.com with fingerprinting protection. This issue pertains to the cookie setting.

@bbondy bbondy added the webcompat/shields Shields is breaking a website. label Dec 20, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Dec 20, 2018
@diracdeltas
Copy link
Member

just ran into this today

@srirambv
Copy link
Contributor

srirambv commented Feb 2, 2019

Same issue with https://itunesconnect.apple.com/login. Adblock has 1 item but disable adblock also doesn;t load the login page. Shields down doesn't load the page either
image

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019
@Maleick
Copy link

Maleick commented Feb 10, 2019

I wanted to give Brave a try and this was my only issue.

All cookies allowed does allow me to use the site.

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Mar 5, 2019
@jonathansampson
Copy link
Contributor

jonathansampson commented Apr 16, 2019

The website attempts to load an iframe from idmsa.apple.com. This page doesn't get the cookie it expects, and therefore responds with an X-FRAME-OPTIONS: DENY header. This header prevents the login form from being displayed.

It is also worth noting (and perhaps worth an issue too) that Cookie Blocking is responsible for this compatibility issue. In spite of this, no indication is given in the Site Shields Panel that this setting has impacted the page in any way:

image

Tested in 0.62.51

@diracdeltas
Copy link
Member

brave/referrer-whitelist#2 should fix this. it doesn't require a new build, just an update to the referrer whitelist JSON file.

@diracdeltas
Copy link
Member

Since this is not part of the regular release cycle (it's a file which is updated independently), any thoughts what milestone this should be marked as, @rebron ?

@rebron
Copy link
Collaborator

rebron commented Aug 13, 2019

@diracdeltas Adding to what was current release at the time which was 65.x hotfix 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes webcompat/shields Shields is breaking a website.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants