-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bandwidth stats is not shown clearly when blue Gradients/Solid background color is selected #25392
Comments
Design ready here Already discussed having the text color changing from white to black depending on the background color contrast. |
Prototype planColors to be inverted when contrast ratio with light background is too low
How to define luminance of colorreferenceshttps://www.w3.org/TR/WCAG20/#contrast-ratiodef%20 contrast ratio
Threshold
In our use case, 4.5:1 would be better cause there are small interactive texts and buttons. how to define luminance of gradient?For now, we should calculate some average color of gradient. |
Great! Yeah agreed 4.5:1 contrast would be ideal |
0.45 seems to be too tight threshhold. Even gray and violet background can't pass it. Let me try 3:1. |
Verified
|
Brave | 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (x86_64) |
---|---|
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991} |
OS | macOS Version 11.7.1 (Build 20G918) |
Steps:
- installed
1.46.81
- launched Brave
- opened a new-tab page
- clicked on
Customize
- clicked on
Solid colors
- selected various shades of colors
- clicked on
Gradients
- selected various shades of gradients
Confirmed I was able to see Bandwidth saved
text and its count, with high contrast
solid 1 | solid 2 | solid 3 | solid 4 | gradient 1 | gradient 2 | gradient 3 | gradient 4 |
---|---|---|---|---|---|---|---|
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
![]() |
Description
Follow up of the PR brave/brave-core#14783
Bandwidth stats is not shown clearly when blue Gradients background color is selected
Steps to Reproduce
Actual result:
Expected result:
Bandwidth stats should be shown clearly when blue Gradients background color is selected
Reproduces how often:
Easy
Brave version (brave://version info)
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc: @simonhong @petemill @sangwoo108
The text was updated successfully, but these errors were encountered: