Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade from Chromium 106.0.5249.40 to Chromium 106.0.5249.55 #25531

Closed
emerick opened this issue Sep 21, 2022 · 6 comments · Fixed by brave/brave-core#15164
Closed

Upgrade from Chromium 106.0.5249.40 to Chromium 106.0.5249.55 #25531

emerick opened this issue Sep 21, 2022 · 6 comments · Fixed by brave/brave-core#15164
Assignees

Comments

@emerick
Copy link
Contributor

emerick commented Sep 21, 2022

Minor Chromium bump.

https://chromium.googlesource.com/chromium/src/+log/106.0.5249.40..106.0.5249.55?pretty=fuller&n=10000

QA tests:

Check branding items
Check for version bump

Additional checks:

No specific code changes in Brave (only line number changes in patches).

@kjozwiak
Copy link
Member

The above requires 1.44.97 or higher for 1.44.x verification 👍

@kjozwiak
Copy link
Member

We'll still need to run through the affected area's mentioned via #24517 (comment) on macOS, Linux and Android Tablet as they haven't ran through the affected areas.

Both Windows & Android ARM (mobile) just need to run a few spot checks.

@kjozwiak
Copy link
Member

kjozwiak commented Sep 22, 2022

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
--- | ---
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Android 13; Build/T1B1.220819.006
Example Example
Screenshot_20220922-151336 Screenshot_20220922-151342

Verification PASSED on Samsung Tab S8 Ultra running Android 12 using the following build(s):

Brave | 1.44.97 Chromium: 106.0.5249.55 (Official Build) (32-bit)
--- | ---
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Android 12; Build/SP2A.220305.013
Example Example
Screenshot_20220923_004345_Brave Screenshot_20220923_004419_Brave

Didn't run through the Bottom toolbar controls area as that's not a feature that's present/enabled on tablets.

Autoplay setting - Passed
  • Verified enabling setting blocks autoplay on all websites
  • Verified adding an Allow exclusion list only allows those webpages to autoplay
  • Verified adding a Block exclusion list blocks only those webpages from autoplay but allows other webpages to autoplay
Colors of controls in settings - Passed
  • Verified control button colous are visible on both dark/light theme
Screenshot_20220923_002958_Brave Screenshot_20220923_003023_Brave Screenshot_20220923_003308_Brave Screenshot_20220923_003317_Brave Screenshot_20220923_003328_Brave
Screenshot_20220923_004100_Brave Screenshot_20220923_004113_Brave Screenshot_20220923_004122_Brave Screenshot_20220923_004133_Brave Screenshot_20220923_004145_Brave
Sharing hub - Passed
  • Verified Google Sharing hub is show by default when Share button is clicked from menu/URL bar
  • Verified Disable Sharing hub is disabled by default
  • Verified enabling Disable Sharing hub doesn't prompt for restart
  • Verified enabling Disable Sharing hub causes to show Android Share menu rather than Google Sharing hub

@GeetaSarvadnya
Copy link

Verification PASSED on

Brave | 1.44.97 Chromium: 106.0.5249.55 (Official Build) (64-bit)
-- | --
Revision | 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS | Windows 10 Version 21H2 (Build 19044.2006)

image

@stephendonner
Copy link

stephendonner commented Sep 23, 2022

Verification PASSED using

Brave 1.44.97 Chromium: 106.0.5249.55 (Official Build) (x86_64)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS macOS Version 11.7 (Build 20G817)

Screen Shot 2022-09-23 at 9 25 00 AM

Also ran through many of these areas via #25518.

Color scheme (omnibox) - PASSED
  • Verified that omnibox color scheme is shown as expected in focused/not focused in light theme
  • Verified that omnibox color scheme is shown as expected in focused/not focused in dark theme

Light theme

focused not focused
Screen Shot 2022-09-23 at 9 26 32 AM Screen Shot 2022-09-23 at 9 26 22 AM

Dark theme

focused not focused
Screen Shot 2022-09-23 at 9 27 41 AM Screen Shot 2022-09-23 at 9 27 21 AM
History page - PASSED
  • Confirmed that history of all the visited websites is listed in brave://history
  • Confirmed that user can search the specific brave history via Search option
  • Confirmed that imported browser history is shown in brave is as expected
    • Confirmed that brave://history UI looks expected and items can be deleted
Example Example Example Example
Screen Shot 2022-09-23 at 9 52 00 AM Screen Shot 2022-09-23 at 9 52 44 AM Screen Shot 2022-09-23 at 9 55 07 AM Screen Shot 2022-09-23 at 9 56 16 AM
Content settings - PASSED
  • Confirmed content settings are working as expected

1. Block cookies content settings

  • Open a site cnn.com
  • Open content settings for cnn.com
  • Block content settings for Location and Window management
  • Reload cnn.com
  • Ensured that Location and Window management permission are blocked for cnn.com
  • Open brave://settings/cookies and Block all cookies
  • Reload cnn.com and ensured that all cookies are blocked on cnn.com
Example Example Example Example Example
Screen Shot 2022-09-23 at 10 10 05 AM Screen Shot 2022-09-23 at 10 14 21 AM Screen Shot 2022-09-23 at 10 14 44 AM Screen Shot 2022-09-23 at 10 15 19 AM Screen Shot 2022-09-23 at 10 16 13 AM

2. Block scripts content settings

  • Block JavaScript for a site via brave://settings/content/javascript
  • Open the site and ensured JavaScript was blocked for the site
  • Open a bunch of websites and ensured JavaScript is not blocked
Example Example Example
Screen Shot 2022-09-23 at 10 32 15 AM Screen Shot 2022-09-23 at 10 27 59 AM Screen Shot 2022-09-23 at 10 28 57 AM

3. Block autoplay global settings

  • Block the autoplay content global settings via brave://settings/content/autoplay
  • Open twitch.tv and ensured no videos are autoplayed
  • Click on a video and play the video manually
  • Click on the "carousel" arrows to advance to the next video
  • Confirm it doesn't auto-play the video
example example example
Screen Shot 2022-09-23 at 10 40 32 AM Screen Shot 2022-09-23 at 10 40 43 AM Screen Shot 2022-09-23 at 10 41 11 AM
Bookmarks - PASSED
  • Confirmed user can add/edit/delete the bookmarks
  • Confirmed bookmarks can be imported via NTP, brave://settings/importData, Hamburger menu - import bookmarks option and brave://bookmarks/ - Import bookmarks
  • Confirmed imported bookmarks can be opened in PT, new window, new tab and in a regular window
  • Confirmed that imported bookmarks are shown in Private and Tor window new tabs
Example Example Example
Screen Shot 2022-09-23 at 11 17 57 AM Screen Shot 2022-09-23 at 11 21 29 AM Screen Shot 2022-09-23 at 11 23 46 AM
Settings UI - PASSED
  • Verified that click on each settings in brave://settings redirected to the intended page
  • Verified the brave://settings UI and ensured UI looks good
  • Verified the icons in the brave://settings page and ensured icons are shown as expected in each settings page
Cookies - PASSED
  • Ensured that cookies are retained in an upgraded profile
  • Ensured cookies settings are working as expected
  • Ensured local and global cookies shield settings are working as expected
  • Open a site cnbc.com
  • Open content settings for cnbc.com
  • Open brave://settings/cookies and Block all cookies
  • Reload cnbc.com and ensured that all cookies are blocked on cnbc.com
  • Open brave://settings/cookies and Allow all cookies
  • Reload cnbc.com and ensured that all cookies are allowed on cnbc.com
Example Example
Screen Shot 2022-09-23 at 12 44 11 PM Screen Shot 2022-09-23 at 12 45 47 PM
Multiple profiles - PASSED
  • Confirmed that user can create multiple profiles (e.g Profile 1 and Profile 2)
  • Change brave://settings and import bookmarks and add extensions in Profile 1
  • Ensured that changes made in settings in Profile 1 are NOT reflected in Profile 2
  • Ensured that the bookmarks and extensions are NOT reflected in Profile 2
  • Enable rewards and update the rewards settings in brave://rewards in Profile 1
  • Ensured that updated rewards settings are specific to profile 1 and are not reflected in Profile 2
First run dialog - PASSED
  • Confirmed first run dialog is shown when Brave is launched in a clean install
  • Confirmed that the dialog content is as expected
  • Confirmed click on Set Brave as default button in first-run dialog set the brave as the default browser and Make Default is removed from brave://settings/getStarted
  • Confirmed click on the Maybe later button in the first-run dialog doesn't set the brave as the default browser and the Make Default option is shown in the brave://settings/getStarted
  • Confirmed esc on the first-run dialog closes it, doesn't set the brave as the default browser, and Make Default is shown in brave://settings/getStarted
  • Confirmed that the user can set the brave as default browser by clicking on the Make Default option is shown in brave://settings/getStarted
Screen Shot 2022-09-23 at 1 00 21 PM
Side panel - PASSED
  • Confirmed that sidebar is not shown by default
  • Confirmed that Reading list icon is added to the sidebar menu
  • Confirmed that reading list panel is shown when user click on the Reading list icon in the sidebar menu
  • Confirmed that user can add the list of websites to the reading list by clicking on the +Add current tab
  • Confirmed that user can add the list of websites to the reading list by right clicking on the tab and choose the option Add tab to the reading list
  • Confirmed that reading list panel can be hidden by clicking on the Reading list icon in the sidebar menu
  • Confirmed that reading list icon is shown in the URL bar, next to wallet icon
  • Confirmed that user can enable/disable the reading list by clicking on the reading list icon (shown in the URL bar)
  • Confirmed that reading list is shown in all the window types (Normal, PT, TOR and Guest window)
  • Websites can't be added to reading list in Guest, encountered Unable to add a site to reading list in Guest window as Add to current tab option is not getting activated #24930
  • Confirmed that sites can be segregated to Read and Unread list
  • Confirmed that sites can be deleted from the reading list
Example Example Example

Screen Shot 2022-09-23 at 2 00 52 PM | Screen Shot 2022-09-23 at 2 03 02 PM | Screen Shot 2022-09-23 at 2 03 07 PM

New tab page - PASSED
  • Ensured Tops sites can be edit/delete via NTP
  • Ensured that NTP stats can be hidden/shown
  • Ensured that a site can be added via NTP
  • Ensured NTP Widget cards can be added/removed
  • Ensured NTP SI works as expected
  • Ensured that click on settings (bookmarks, history, settings and Brave Talk) shortcuts works as expected
  • Ensured that the existing features upload your own and Brave background works as expected
  • Confirmed that NTP SI are shown in the order 2, 4, 8 tabs
  • Confirmed that user can select the solid background for NTP
  • Confirmed that user can choose the individual solid background via NTP
  • Confirmed that same solid background is shown on each the NTP when the individual solid background is selected
  • Confirmed that the different solid background is shown on each the NTP when Refresh on every new tab switch is ON

Settings comparison

Verified that the Language settings are updated as part of CR 106
Screen Shot 2022-09-23 at 1 31 58 PM

Verified that content additional setting is renamed as Windows management as part of CR 106
Screen Shot 2022-09-23 at 1 33 20 PM

New settings Tab hover mode and Side panel settings are added as part of Brave in nightly (1.45.x) which are already merged in Beta (1.44.x)
Screen Shot 2022-09-23 at 1 33 50 PM

Verified that the Reading list sync datatype has been added in brave://sync as part of Brave

Screen Shot 2022-09-23 at 1 34 24 PM

Verified each settings in brave://settings page and ensured each settings works as expected

Components updater

Brave startup calls

  • Confirmed that only Brave domains are listed in Charles Proxy when the build is launched with a clean profile
  • Confirmed no calls to google.com, gstatic, etc domains when the build is launched with a clean profile

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Sep 23, 2022
@kjozwiak
Copy link
Member

Added QA/No & release-notes/exclude in favour of #25609 👍 Going to leave a quick summary via #25609 re: what's remaining of running through the affected area's.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants