Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in brave://flags for Enable Brave New Subscribe Button #25386

Closed
MadhaviSeelam opened this issue Sep 14, 2022 · 2 comments · Fixed by brave/brave-core#15100
Closed

Typo in brave://flags for Enable Brave New Subscribe Button #25386

MadhaviSeelam opened this issue Sep 14, 2022 · 2 comments · Fixed by brave/brave-core#15100

Comments

@MadhaviSeelam
Copy link

Description

Steps to Reproduce

  1. Install 1.44.83
  2. launch Brave
  3. open brave://flags
  4. search for Enable Brave News Subscribe Button

Actual result:

Reads Enable Brave New Subscribe Button

image

Expected result:

Should read Enable Brave News Subscribe Button

Reproduces how often:

Easily

Brave version (brave://version info)

Brave 1.44.83 Chromium: 105.0.5195.102 (Official Build) beta (64-bit)
Revision 4c16f5ffcc2da70ee2600d5db77bed423ac03a5a-refs/branch-heads/5195_55@{#4}
OS Windows 11 Version 21H2 (Build 22000.856)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? N/A

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@rebron @fallaciousreasoning @stephendonner

@stephendonner
Copy link

Verified PASSED using

Brave 1.45.74 Chromium: 106.0.5249.55 (Official Build) beta (x86_64)
Revision 4d5f098fca6ab7f4b6b7c240be3d9593c2357709-refs/branch-heads/5249@{#531}
OS macOS Version 11.7 (Build 20G817)

Confirmed the flag now correctly reads Enable Brave News Subscribe Button

Screen Shot 2022-09-26 at 7 11 24 PM

@MadhaviSeelam
Copy link
Author

Verification PASSED using

Brave | 1.45.75 Chromium: 106.0.5249.65 (Official Build) beta (64-bit)
-- | --
Revision | 3269dc3633cdd2ab94546fdbe54962e45b17a6e0-refs/branch-heads/5249@{#580}
OS | Windows 11 Version 21H2 (Build 22000.978)

Verified using original STR from #25386 (comment)

Confirmed correct text for the flag Enable Brave News Subscribe Button

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants